eng, automation, fix hardcode on resources service#46126
Merged
weidongxu-microsoft merged 3 commits intoAzure:mainfrom Jul 23, 2025
Merged
eng, automation, fix hardcode on resources service#46126weidongxu-microsoft merged 3 commits intoAzure:mainfrom
weidongxu-microsoft merged 3 commits intoAzure:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes hardcoded values and formatting issues in the Azure SDK Java automation scripts. The changes improve code maintainability by removing hardcoded package tags and improving code formatting consistency.
- Updates hardcoded "package-resources-2021-01" tag to "package-resources-2025-04"
- Adds logic to conditionally apply tag detection only for "resources" service and spec
- Improves code formatting by using consistent quote styles and proper line breaks
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| eng/automation/parameters.py | Reformats FLUENTPREMIUM_ARGUMENTS with proper line breaks and parentheses |
| eng/automation/generate_utils.py | Changes single quotes to double quotes for string literals in file opening |
| eng/automation/generate.py | Updates hardcoded tag version, adds conditional logic for resources service, and fixes formatting issues |
XiaofeiCao
approved these changes
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error from Azure/azure-rest-api-specs#36124
After deployments get split from resources, they are now in different readme/folder.
code change 0030650
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines