Skip to content

Comments

eng, automation, fix hardcode on resources service#46126

Merged
weidongxu-microsoft merged 3 commits intoAzure:mainfrom
weidongxu-microsoft:eng_automation-fix-resources-tag
Jul 23, 2025
Merged

eng, automation, fix hardcode on resources service#46126
weidongxu-microsoft merged 3 commits intoAzure:mainfrom
weidongxu-microsoft:eng_automation-fix-resources-tag

Conversation

@weidongxu-microsoft
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft commented Jul 23, 2025

Error from Azure/azure-rest-api-specs#36124
After deployments get split from resources, they are now in different readme/folder.

code change 0030650

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@weidongxu-microsoft weidongxu-microsoft marked this pull request as ready for review July 23, 2025 05:48
Copilot AI review requested due to automatic review settings July 23, 2025 05:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes hardcoded values and formatting issues in the Azure SDK Java automation scripts. The changes improve code maintainability by removing hardcoded package tags and improving code formatting consistency.

  • Updates hardcoded "package-resources-2021-01" tag to "package-resources-2025-04"
  • Adds logic to conditionally apply tag detection only for "resources" service and spec
  • Improves code formatting by using consistent quote styles and proper line breaks

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
eng/automation/parameters.py Reformats FLUENTPREMIUM_ARGUMENTS with proper line breaks and parentheses
eng/automation/generate_utils.py Changes single quotes to double quotes for string literals in file opening
eng/automation/generate.py Updates hardcoded tag version, adds conditional logic for resources service, and fixes formatting issues

@weidongxu-microsoft weidongxu-microsoft merged commit ef09457 into Azure:main Jul 23, 2025
18 checks passed
@weidongxu-microsoft weidongxu-microsoft deleted the eng_automation-fix-resources-tag branch July 23, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants