Added REST API link in file JAVA doc #4568

sima-zhu · 2019-07-24T22:06:11Z

Minor fix for signature name
Minor fix for javadoc indentation
Added REST API link for file

* SAS implementation * Fixed some minor formatting issues * Fixed checkstyle problems and test issue

Removes RawClients from Storage Blobs

…to ContainerClient (Azure#4376) * Removed raw clients * Added deleteContainer to StorageClient * Added getAppendBlob with snapshot to ContainerClient

* Initial check in for storage queue

* Finished the restructure, refactor builder. Added sleep in record feature. Linting

Merges AppendBlobClientBuilder, BlobClientBuilder, BlockBlobClientBuilder, and PageBlobClientBuilder into a single builder class BlobClientBuilder. Additionally, JavaDoc comments for the other builder classes, ContainerClientBuilder and StorageAccountClientBuilder, were cleaned up and the way the endpoint is handled in builders was changed.

sima-zhu · 2019-07-31T16:33:43Z

@alzimmermsft Could you take a look at again and leave comments for what you have done for the queue PR? I would like to keep consistent with Queue. Thanks!

…into storage-javadoc

rickle-msft · 2019-07-31T22:27:25Z

public Flux<HandleItem> getHandles(Integer maxResult, boolean recursive) {

This name doesn't seem right. I thought we didn't use "get" for apis that make service calls. Unless there's some reason why we deviated here, can we open an item to change this name? #Resolved

Refers to: sdk/storage/azure-storage-file/src/main/java/com/azure/storage/file/DirectoryAsyncClient.java:298 in ed97215. [](commit_id = ed97215, deletion_comment = False)

rickle-msft · 2019-07-31T22:29:16Z

sdk/storage/azure-storage-file/src/main/java/com/azure/storage/file/DirectoryClient.java

     * {@codesnippet com.azure.storage.file.directoryClient.createDirectory}
     *
+     * <p>For more information, see the
+     * <a href="https://docs.microsoft.com/en-us/rest/api/storageservices/list-directories-and-files">Azure Docs</a>.</p>


/list-directories-and-files" [](start = 73, length = 28)

Incorrect link #Resolved

Done with the checking for the entire file. #Resolved

rickle-msft · 2019-07-31T22:29:26Z

sdk/storage/azure-storage-file/src/main/java/com/azure/storage/file/DirectoryClient.java

     * {@codesnippet com.azure.storage.file.directoryClient.create#map}
     *
+     * <p>For more information, see the
+     * <a href="https://docs.microsoft.com/en-us/rest/api/storageservices/list-directories-and-files">Azure Docs</a>.</p>


list-directories-and-files [](start = 74, length = 26)

Incorrect link #Resolved

Done. #Resolved

rickle-msft · 2019-07-31T22:29:58Z

sdk/storage/azure-storage-file/src/main/java/com/azure/storage/file/DirectoryClient.java

     * {@codesnippet com.azure.storage.file.directoryClient.createSubDirectory#string}
     *
+     * <p>For more information, see the
+     * <a href="https://docs.microsoft.com/en-us/rest/api/storageservices/list-directories-and-files">Azure Docs</a>.</p>


list-directories-and-files [](start = 74, length = 26)

Incorrect link #Resolved

Done. #Resolved

rickle-msft · 2019-07-31T22:30:11Z

sdk/storage/azure-storage-file/src/main/java/com/azure/storage/file/DirectoryClient.java

     * {@codesnippet com.azure.storage.file.directoryClient.createSubDirectory#string-map}
     *
+     * <p>For more information, see the
+     * <a href="https://docs.microsoft.com/en-us/rest/api/storageservices/list-directories-and-files">Azure Docs</a>.</p>


list-directories-and-files [](start = 74, length = 26)

incorrect link #Resolved

Done. #Resolved

rickle-msft · 2019-07-31T22:33:35Z

 * {@codesnippet com.azure.storage.file.fileClient.downloadWithProperties}

Why no link here? It looks like there are a couple methods that don't have docs #Resolved

Refers to: sdk/storage/azure-storage-file/src/main/java/com/azure/storage/file/FileClient.java:189 in ed97215. [](commit_id = ed97215, deletion_comment = False)

sima-zhu · 2019-07-31T22:35:24Z

 * {@codesnippet com.azure.storage.file.fileClient.downloadWithProperties}
Why no link here? It looks like there are a couple methods that don't have docs

Refers to: sdk/storage/azure-storage-file/src/main/java/com/azure/storage/file/FileClient.java:189 in ed97215. [](commit_id = ed97215, deletion_comment = False)

I do not find the appropriate link for this API, same applies to others which leave blank.
@rickle-msft

rickle-msft · 2019-07-31T22:37:02Z

Should just be the download api

In reply to: 517047843 [](ancestors = 517047843)

rickle-msft · 2019-07-31T22:37:27Z

The description says you bumped the version number, but I only see edits to Java files? #Resolved

sima-zhu · 2019-07-31T22:38:36Z

The description says you bumped the version number, but I only see edits to Java files?

That has been done by other PR. Will remove the description. @rickle-msft #Resolved

sima-zhu · 2019-07-31T22:39:52Z

Should just be the download api

In reply to: 517047843 [](ancestors = 517047843)

I only saw the getFile which is corresponding to downloadToFile. It does not provide properties for download. @rickle-msft

sima-zhu · 2019-07-31T22:44:18Z

public Flux<HandleItem> getHandles(Integer maxResult, boolean recursive) {
This name doesn't seem right. I thought we didn't use "get" for apis that make service calls. Unless there's some reason why we deviated here, can we open an item to change this name?

Refers to: sdk/storage/azure-storage-file/src/main/java/com/azure/storage/file/DirectoryAsyncClient.java:298 in ed97215. [](commit_id = ed97215, deletion_comment = False)

@rickle-msft I had the method name from design doc. I do not have the background of why it names like this. I can create an issue for this. #4754

rickle-msft

gapra-msft and others added 11 commits July 12, 2019 11:57

Storage SAS implementation (Azure#4404)

1ec9438

* SAS implementation * Fixed some minor formatting issues * Fixed checkstyle problems and test issue

Merge branch 'master' into storage-post-review1-dev

78db8d4

Merge branch 'master' into storage-post-review1-dev

69026ba

Remove RawClients from Blobs (Azure#4375)

be429c3

Removes RawClients from Storage Blobs

Add deleteContainer to StorageClient and getBlobClient with Snapshot …

b00cdc6

…to ContainerClient (Azure#4376) * Removed raw clients * Added deleteContainer to StorageClient * Added getAppendBlob with snapshot to ContainerClient

Merge branch 'master' into storage-post-review1-dev

da7ebb6

Storage queue linting, builder refactor, tests (Azure#4383)

78ea66b

* Initial check in for storage queue

Initial checkin for Storage file (Azure#4414)

44fb56e

* Finished the restructure, refactor builder. Added sleep in record feature. Linting

Merge branch 'master' into storage-post-review1-dev

53b2854

Added REST API link in file JAVA doc

2f88e9c

sima-zhu requested review from alzimmermsft and rickle-msft July 24, 2019 22:06

alzimmermsft approved these changes Jul 24, 2019

View reviewed changes

sima-zhu changed the base branch from storage-post-review1-dev to master July 26, 2019 18:55

sima-zhu self-assigned this Jul 29, 2019

Merge from mainline

165e16a

sima-zhu requested a review from jaschrep-msft as a code owner July 29, 2019 22:24

kurtzeborn added Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) labels Jul 30, 2019

Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java …

8b8ec82

…into storage-javadoc

sima-zhu requested a review from alzimmermsft July 31, 2019 18:49

alzimmermsft approved these changes Jul 31, 2019

View reviewed changes

Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java …

ed97215

…into storage-javadoc

rickle-msft reviewed Jul 31, 2019

View reviewed changes

Addressed the feedback.

238dec7

sima-zhu requested a review from rickle-msft July 31, 2019 23:06

sima-zhu added 2 commits July 31, 2019 16:41

Make the missed one.

81721cb

Added the Rest API links according to the storage team suggestion.

ef3b376

rickle-msft approved these changes Aug 2, 2019

View reviewed changes

sima-zhu merged commit 885bf9c into Azure:master Aug 2, 2019

srnagar pushed a commit to srnagar/azure-sdk-for-java that referenced this pull request Aug 5, 2019

Added REST API link in file JAVA doc (Azure#4568)

b46cb82

sima-zhu deleted the storage-javadoc branch February 23, 2021 19:04

Added REST API link in file JAVA doc #4568

Added REST API link in file JAVA doc #4568

Uh oh!

Conversation

sima-zhu commented Jul 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sima-zhu commented Jul 31, 2019

Uh oh!

rickle-msft commented Jul 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rickle-msft Jul 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sima-zhu Jul 31, 2019 • edited by rickle-msft Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rickle-msft Jul 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sima-zhu Jul 31, 2019 • edited by rickle-msft Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rickle-msft Jul 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sima-zhu Jul 31, 2019 • edited by rickle-msft Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rickle-msft Jul 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sima-zhu Jul 31, 2019 • edited by rickle-msft Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rickle-msft commented Jul 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sima-zhu commented Jul 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rickle-msft commented Jul 31, 2019

Uh oh!

rickle-msft commented Jul 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sima-zhu commented Jul 31, 2019 • edited by rickle-msft Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sima-zhu commented Jul 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sima-zhu commented Jul 31, 2019

Uh oh!

rickle-msft left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sima-zhu commented Jul 24, 2019 •

edited

Loading

rickle-msft commented Jul 31, 2019 •

edited

Loading

rickle-msft Jul 31, 2019 •

edited

Loading

sima-zhu Jul 31, 2019 •

edited by rickle-msft

Loading

rickle-msft Jul 31, 2019 •

edited

Loading

sima-zhu Jul 31, 2019 •

edited by rickle-msft

Loading

rickle-msft Jul 31, 2019 •

edited

Loading

sima-zhu Jul 31, 2019 •

edited by rickle-msft

Loading

rickle-msft Jul 31, 2019 •

edited

Loading

sima-zhu Jul 31, 2019 •

edited by rickle-msft

Loading

rickle-msft commented Jul 31, 2019 •

edited

Loading

sima-zhu commented Jul 31, 2019 •

edited

Loading

rickle-msft commented Jul 31, 2019 •

edited

Loading

sima-zhu commented Jul 31, 2019 •

edited by rickle-msft

Loading

sima-zhu commented Jul 31, 2019 •

edited

Loading