[AutoPR azure-resourcemanager-oracledatabase]-generated-from-SDK Generation - Java-4939103#45582
Conversation
…onfig.yaml', API Version: 2025-03-01, SDK Release Type: stable, and CommitSHA: '3c2966598b7966dcca302d07dd7d28b1d1d744f3' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs'
API Change CheckAPIView identified API level changes in this PR and created the following API reviews com.azure.resourcemanager:azure-resourcemanager-oracledatabase |
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the Oracle Database Management Java SDK by regenerating client interfaces and manager classes using Microsoft’s new TypeSpec Code Generator. Key changes include updating code generator comments, adjusting API documentation and parameter descriptions, and updating version strings and dependency declarations.
Reviewed Changes
Copilot reviewed 554 out of 554 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/oracledatabase/azure-resourcemanager-oracledatabase/src/main/java/com/azure/resourcemanager/oracledatabase/fluent/* | Updated generated interfaces’ comments and parameter descriptors to reflect TypeSpec Code Generator usage and improved naming consistency. |
| sdk/oracledatabase/azure-resourcemanager-oracledatabase/OracleDatabaseManager.java | Refactored manager class to update client builder usage, reordering fields, and updating Javadoc to match the new management client type. |
| sdk/oracledatabase/azure-resourcemanager-oracledatabase/pom.xml | Updated version number from “1.1.0-beta.1” to “1.1.0” and removed a beta indicator. |
| sdk/oracledatabase/azure-resourcemanager-oracledatabase/README.md | Revised package description and authentication sample details. |
| eng/versioning/version_client.txt | Updated version mapping for the Oracle Database SDK module. |
Comments suppressed due to low confidence (3)
sdk/oracledatabase/azure-resourcemanager-oracledatabase/src/main/java/com/azure/resourcemanager/oracledatabase/fluent/DnsPrivateZonesClient.java:22
- [nitpick] Consider renaming the parameter 'dnsprivatezonename' to 'dnsPrivateZoneName' to follow standard camelCase conventions.
* @param dnsprivatezonename DnsPrivateZone name.
sdk/oracledatabase/azure-resourcemanager-oracledatabase/src/main/java/com/azure/resourcemanager/oracledatabase/fluent/DnsPrivateViewsClient.java:22
- [nitpick] Consider renaming 'dnsprivateviewocid' to 'dnsPrivateViewOcid' for improved readability and consistency with Java naming conventions.
* @param dnsprivateviewocid DnsPrivateView OCID.
sdk/oracledatabase/azure-resourcemanager-oracledatabase/OracleDatabaseManager.java:617
- Update the Javadoc for serviceClient() to reflect that it returns an OracleDatabaseManagementClient instead of OracleDatabaseResourceManager to avoid confusion.
public OracleDatabaseManagementClient serviceClient() {
|
/check-enforcer override |
Configurations: 'specification/oracle/Oracle.Database.Management/tspconfig.yaml', API Version: 2025-03-01, SDK Release Type: stable, and CommitSHA: '3c2966598b7966dcca302d07dd7d28b1d1d744f3' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs'
there is breaks (some "required" <-> "optional" may come from service), but so far nothing major
breakdown in #45575