Skip to content

GA5 Linting Issues + Re-recording tests #45448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025
Merged

GA5 Linting Issues + Re-recording tests #45448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/communication/azure-communication-callautomation/assets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "java",
"TagPrefix": "java/communication/azure-communication-callautomation",
"Tag": "java/communication/azure-communication-callautomation_6dc9a150d6"
"Tag": "java/communication/azure-communication-callautomation_33108318f9"
}
2 changes: 1 addition & 1 deletion ...automation/src/main/java/com/azure/communication/callautomation/models/StreamingData.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
/** The abstract class used as parent of Streaming data such as Audio, Transcription, or Captions. */
public abstract class StreamingData {

private StreamingDataKind streamingDataKind;
private final StreamingDataKind streamingDataKind;

/**
* Creates an instance of {@link StreamingData}.
Expand Down
1 change: 0 additions & 1 deletion ...ion/src/main/java/com/azure/communication/callautomation/models/TranscriptionOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

package com.azure.communication.callautomation.models;

import com.azure.communication.callautomation.implementation.models.WebSocketTranscriptionOptionsInternal;
import com.azure.core.annotation.Fluent;

/** The TranscriptionOptions model. */
Expand Down
2 changes: 1 addition & 1 deletion ...a/com/azure/communication/callautomation/CallAutomationAsyncClientAutomatedLiveTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ public void createVOIPCallAndRejectAutomatedTest(HttpClient httpClient) {
assertNotNull(callerConnectionId);

// wait for the incomingCallContext
String incomingCallContext = waitForIncomingCallContext(uniqueId, Duration.ofSeconds(10));
String incomingCallContext = waitForIncomingCallContext(uniqueId, Duration.ofSeconds(20));
assertNotNull(incomingCallContext);

// rejet the call
Expand Down
3 changes: 0 additions & 3 deletions ...tion/src/test/java/com/azure/communication/callautomation/CallAutomationUnitTestBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,7 @@
import com.azure.communication.callautomation.implementation.models.PhoneNumberIdentifierModel;
import com.azure.communication.callautomation.models.MediaStreamingAudioChannel;
import com.azure.communication.callautomation.models.MediaStreamingOptions;
import com.azure.communication.callautomation.models.MediaStreamingContentType;
import com.azure.communication.callautomation.models.MediaStreamingTransport;
import com.azure.communication.callautomation.models.TranscriptionOptions;
import com.azure.communication.callautomation.models.StreamingTransport;
import com.azure.communication.common.CommunicationUserIdentifier;
import com.azure.core.http.HttpClient;
import com.azure.core.http.HttpHeaders;
Expand Down
3 changes: 0 additions & 3 deletions ...rc/test/java/com/azure/communication/callautomation/CallMediaAsyncAutomatedLiveTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,12 @@
import com.azure.communication.phonenumbers.models.PurchasedPhoneNumber;
import com.azure.communication.callautomation.models.CallParticipant;
import com.azure.communication.callautomation.models.MediaStreamingAudioChannel;
import com.azure.communication.callautomation.models.MediaStreamingContentType;
import com.azure.communication.callautomation.models.MediaStreamingOptions;
import com.azure.communication.callautomation.models.MediaStreamingTransport;
import com.azure.communication.callautomation.models.TranscriptionOptions;
import com.azure.communication.callautomation.models.StartMediaStreamingOptions;
import com.azure.communication.callautomation.models.StopMediaStreamingOptions;
import com.azure.communication.callautomation.models.StartTranscriptionOptions;
import com.azure.communication.callautomation.models.StopTranscriptionOptions;
import com.azure.communication.callautomation.models.StreamingTransport;
import com.azure.communication.callautomation.models.events.MediaStreamingStarted;
import com.azure.communication.callautomation.models.events.MediaStreamingStopped;
import com.azure.communication.callautomation.models.events.TranscriptionStarted;
Expand Down
2 changes: 1 addition & 1 deletion ...ure-communication-callautomation/src/test/resources/createACSCallAndUnmixedAudioTest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
["{\"to\":{\"kind\":\"communicationUser\",\"rawId\":\"REDACTED\",\"communicationUser\":{\"id\":\"REDACTED\"}},\"from\":{\"kind\":\"communicationUser\",\"rawId\":\"REDACTED\",\"communicationUser\":{\"id\":\"REDACTED\"}},\"serverCallId\":\"REDACTED\",\"callerDisplayName\":\"\",\"incomingCallContext\":\"REDACTED\",\"correlationId\":\"d4a4de0e-22bc-447b-956a-bd07392b8d50\"}","[{\"id\":\"REDACTED\",\"source\":\"calling/callConnections/02002680-86ce-4b60-8520-dcf7a51fb423\",\"type\":\"Microsoft.Communication.ParticipantsUpdated\",\"data\":{\"participants\":[{\"identifier\":{\"rawId\":\"REDACTED\",\"kind\":\"communicationUser\",\"communicationUser\":{\"id\":\"REDACTED\"}},\"isMuted\":false,\"isOnHold\":false},{\"identifier\":{\"rawId\":\"REDACTED\",\"kind\":\"communicationUser\",\"communicationUser\":{\"id\":\"REDACTED\"}},\"isMuted\":false,\"isOnHold\":false}],\"sequenceNumber\":1,\"resultInformation\":{\"code\":200,\"subCode\":0,\"message\":\"\"},\"version\":\"2025-05-15\",\"callConnectionId\":\"02002680-86ce-4b60-8520-dcf7a51fb423\",\"serverCallId\":\"REDACTED\",\"correlationId\":\"d4a4de0e-22bc-447b-956a-bd07392b8d50\",\"publicEventType\":\"Microsoft.Communication.ParticipantsUpdated\"},\"time\":\"2025-05-20T10:08:23.997544\\u002B00:00\",\"specversion\":\"1.0\",\"datacontenttype\":\"application/json\",\"subject\":\"calling/callConnections/02002680-86ce-4b60-8520-dcf7a51fb423\"}]","[{\"id\":\"REDACTED\",\"source\":\"calling/callConnections/02002680-86ce-4b60-8520-dcf7a51fb423\",\"type\":\"Microsoft.Communication.CallConnected\",\"data\":{\"version\":\"2025-05-15\",\"resultInformation\":{\"code\":200,\"subCode\":0,\"message\":\"\"},\"callConnectionId\":\"02002680-86ce-4b60-8520-dcf7a51fb423\",\"serverCallId\":\"REDACTED\",\"correlationId\":\"d4a4de0e-22bc-447b-956a-bd07392b8d50\",\"publicEventType\":\"Microsoft.Communication.CallConnected\"},\"time\":\"2025-05-20T10:08:24.1018019\\u002B00:00\",\"specversion\":\"1.0\",\"datacontenttype\":\"application/json\",\"subject\":\"calling/callConnections/02002680-86ce-4b60-8520-dcf7a51fb423\"}]","[{\"id\":\"REDACTED\",\"source\":\"calling/callConnections/02002680-86ce-4b60-8520-dcf7a51fb423\",\"type\":\"Microsoft.Communication.ParticipantsUpdated\",\"data\":{\"participants\":[{\"identifier\":{\"rawId\":\"REDACTED\",\"kind\":\"communicationUser\",\"communicationUser\":{\"id\":\"REDACTED\"}},\"isMuted\":false,\"isOnHold\":false},{\"identifier\":{\"rawId\":\"REDACTED\",\"kind\":\"communicationUser\",\"communicationUser\":{\"id\":\"REDACTED\"}},\"isMuted\":false,\"isOnHold\":false}],\"sequenceNumber\":3,\"resultInformation\":{\"code\":200,\"subCode\":0,\"message\":\"\"},\"version\":\"2025-05-15\",\"callConnectionId\":\"02002680-86ce-4b60-8520-dcf7a51fb423\",\"serverCallId\":\"REDACTED\",\"correlationId\":\"d4a4de0e-22bc-447b-956a-bd07392b8d50\",\"publicEventType\":\"Microsoft.Communication.ParticipantsUpdated\"},\"time\":\"2025-05-20T10:08:28.763855\\u002B00:00\",\"specversion\":\"1.0\",\"datacontenttype\":\"application/json\",\"subject\":\"calling/callConnections/02002680-86ce-4b60-8520-dcf7a51fb423\"}]","[{\"id\":\"REDACTED\",\"source\":\"calling/callConnections/02002680-86ce-4b60-8520-dcf7a51fb423\",\"type\":\"Microsoft.Communication.ParticipantsUpdated\",\"data\":{\"participants\":[{\"identifier\":{\"rawId\":\"REDACTED\",\"kind\":\"communicationUser\",\"communicationUser\":{\"id\":\"REDACTED\"}},\"isMuted\":false,\"isOnHold\":false},{\"identifier\":{\"rawId\":\"REDACTED\",\"kind\":\"communicationUser\",\"communicationUser\":{\"id\":\"REDACTED\"}},\"isMuted\":false,\"isOnHold\":false}],\"sequenceNumber\":4,\"resultInformation\":{\"code\":200,\"subCode\":0,\"message\":\"\"},\"version\":\"2025-05-15\",\"callConnectionId\":\"02002680-86ce-4b60-8520-dcf7a51fb423\",\"serverCallId\":\"REDACTED\",\"correlationId\":\"d4a4de0e-22bc-447b-956a-bd07392b8d50\",\"publicEventType\":\"Microsoft.Communication.ParticipantsUpdated\"},\"time\":\"2025-05-20T10:08:29.156359\\u002B00:00\",\"specversion\":\"1.0\",\"datacontenttype\":\"application/json\",\"subject\":\"calling/callConnections/02002680-86ce-4b60-8520-dcf7a51fb423\"}]","[{\"id\":\"REDACTED\",\"source\":\"calling/callConnections/02002680-86ce-4b60-8520-dcf7a51fb423\",\"type\":\"Microsoft.Communication.CallDisconnected\",\"data\":{\"version\":\"2025-05-15\",\"resultInformation\":{\"code\":200,\"subCode\":7000,\"message\":\"The conversation has ended. DiagCode: 0#7000.@\"},\"callConnectionId\":\"02002680-86ce-4b60-8520-dcf7a51fb423\",\"serverCallId\":\"REDACTED\",\"correlationId\":\"d4a4de0e-22bc-447b-956a-bd07392b8d50\",\"publicEventType\":\"Microsoft.Communication.CallDisconnected\"},\"time\":\"2025-05-20T10:08:29.2196006\\u002B00:00\",\"specversion\":\"1.0\",\"datacontenttype\":\"application/json\",\"subject\":\"calling/callConnections/02002680-86ce-4b60-8520-dcf7a51fb423\"}]"]
["{\"to\":{\"kind\":\"communicationUser\",\"rawId\":\"REDACTED\",\"communicationUser\":{\"id\":\"REDACTED\"}},\"from\":{\"kind\":\"communicationUser\",\"rawId\":\"REDACTED\",\"communicationUser\":{\"id\":\"REDACTED\"}},\"serverCallId\":\"REDACTED\",\"callerDisplayName\":\"\",\"incomingCallContext\":\"REDACTED\",\"correlationId\":\"bc5d7e7b-92f0-43f5-80c5-fe5a35ea40f8\"}","[{\"id\":\"REDACTED\",\"source\":\"calling/callConnections/1a006780-0481-4472-a2b1-6d4535fbe7f9\",\"type\":\"Microsoft.Communication.ParticipantsUpdated\",\"data\":{\"participants\":[{\"identifier\":{\"rawId\":\"REDACTED\",\"kind\":\"communicationUser\",\"communicationUser\":{\"id\":\"REDACTED\"}},\"isMuted\":false,\"isOnHold\":false},{\"identifier\":{\"rawId\":\"REDACTED\",\"kind\":\"communicationUser\",\"communicationUser\":{\"id\":\"REDACTED\"}},\"isMuted\":false,\"isOnHold\":false}],\"sequenceNumber\":1,\"resultInformation\":{\"code\":200,\"subCode\":0,\"message\":\"\"},\"version\":\"2025-05-15\",\"callConnectionId\":\"1a006780-0481-4472-a2b1-6d4535fbe7f9\",\"serverCallId\":\"REDACTED\",\"correlationId\":\"bc5d7e7b-92f0-43f5-80c5-fe5a35ea40f8\",\"publicEventType\":\"Microsoft.Communication.ParticipantsUpdated\"},\"time\":\"2025-05-22T17:25:16.5681527\\u002B00:00\",\"specversion\":\"1.0\",\"datacontenttype\":\"application/json\",\"subject\":\"calling/callConnections/1a006780-0481-4472-a2b1-6d4535fbe7f9\"}]","[{\"id\":\"REDACTED\",\"source\":\"calling/callConnections/1a006780-0481-4472-a2b1-6d4535fbe7f9\",\"type\":\"Microsoft.Communication.CallConnected\",\"data\":{\"version\":\"2025-05-15\",\"resultInformation\":{\"code\":200,\"subCode\":0,\"message\":\"\"},\"callConnectionId\":\"1a006780-0481-4472-a2b1-6d4535fbe7f9\",\"serverCallId\":\"REDACTED\",\"correlationId\":\"bc5d7e7b-92f0-43f5-80c5-fe5a35ea40f8\",\"publicEventType\":\"Microsoft.Communication.CallConnected\"},\"time\":\"2025-05-22T17:25:16.7573562\\u002B00:00\",\"specversion\":\"1.0\",\"datacontenttype\":\"application/json\",\"subject\":\"calling/callConnections/1a006780-0481-4472-a2b1-6d4535fbe7f9\"}]","[{\"id\":\"REDACTED\",\"source\":\"calling/callConnections/1a006780-0481-4472-a2b1-6d4535fbe7f9\",\"type\":\"Microsoft.Communication.ParticipantsUpdated\",\"data\":{\"participants\":[{\"identifier\":{\"rawId\":\"REDACTED\",\"kind\":\"communicationUser\",\"communicationUser\":{\"id\":\"REDACTED\"}},\"isMuted\":false,\"isOnHold\":false},{\"identifier\":{\"rawId\":\"REDACTED\",\"kind\":\"communicationUser\",\"communicationUser\":{\"id\":\"REDACTED\"}},\"isMuted\":false,\"isOnHold\":false}],\"sequenceNumber\":3,\"resultInformation\":{\"code\":200,\"subCode\":0,\"message\":\"\"},\"version\":\"2025-05-15\",\"callConnectionId\":\"1a006780-0481-4472-a2b1-6d4535fbe7f9\",\"serverCallId\":\"REDACTED\",\"correlationId\":\"bc5d7e7b-92f0-43f5-80c5-fe5a35ea40f8\",\"publicEventType\":\"Microsoft.Communication.ParticipantsUpdated\"},\"time\":\"2025-05-22T17:25:21.5656009\\u002B00:00\",\"specversion\":\"1.0\",\"datacontenttype\":\"application/json\",\"subject\":\"calling/callConnections/1a006780-0481-4472-a2b1-6d4535fbe7f9\"}]","[{\"id\":\"REDACTED\",\"source\":\"calling/callConnections/1a006780-0481-4472-a2b1-6d4535fbe7f9\",\"type\":\"Microsoft.Communication.ParticipantsUpdated\",\"data\":{\"participants\":[{\"identifier\":{\"rawId\":\"REDACTED\",\"kind\":\"communicationUser\",\"communicationUser\":{\"id\":\"REDACTED\"}},\"isMuted\":false,\"isOnHold\":false},{\"identifier\":{\"rawId\":\"REDACTED\",\"kind\":\"communicationUser\",\"communicationUser\":{\"id\":\"REDACTED\"}},\"isMuted\":false,\"isOnHold\":false}],\"sequenceNumber\":4,\"resultInformation\":{\"code\":200,\"subCode\":0,\"message\":\"\"},\"version\":\"2025-05-15\",\"callConnectionId\":\"1a006780-0481-4472-a2b1-6d4535fbe7f9\",\"serverCallId\":\"REDACTED\",\"correlationId\":\"bc5d7e7b-92f0-43f5-80c5-fe5a35ea40f8\",\"publicEventType\":\"Microsoft.Communication.ParticipantsUpdated\"},\"time\":\"2025-05-22T17:25:21.676686\\u002B00:00\",\"specversion\":\"1.0\",\"datacontenttype\":\"application/json\",\"subject\":\"calling/callConnections/1a006780-0481-4472-a2b1-6d4535fbe7f9\"}]","[{\"id\":\"REDACTED\",\"source\":\"calling/callConnections/1a006780-0481-4472-a2b1-6d4535fbe7f9\",\"type\":\"Microsoft.Communication.ParticipantsUpdated\",\"data\":{\"participants\":[{\"identifier\":{\"rawId\":\"REDACTED\",\"kind\":\"communicationUser\",\"communicationUser\":{\"id\":\"REDACTED\"}},\"isMuted\":false,\"isOnHold\":false},{\"identifier\":{\"rawId\":\"REDACTED\",\"kind\":\"communicationUser\",\"communicationUser\":{\"id\":\"REDACTED\"}},\"isMuted\":false,\"isOnHold\":false}],\"sequenceNumber\":5,\"resultInformation\":{\"code\":200,\"subCode\":0,\"message\":\"\"},\"version\":\"2025-05-15\",\"callConnectionId\":\"1a006780-0481-4472-a2b1-6d4535fbe7f9\",\"serverCallId\":\"REDACTED\",\"correlationId\":\"bc5d7e7b-92f0-43f5-80c5-fe5a35ea40f8\",\"publicEventType\":\"Microsoft.Communication.ParticipantsUpdated\"},\"time\":\"2025-05-22T17:25:21.8002998\\u002B00:00\",\"specversion\":\"1.0\",\"datacontenttype\":\"application/json\",\"subject\":\"calling/callConnections/1a006780-0481-4472-a2b1-6d4535fbe7f9\"}]","[{\"id\":\"REDACTED\",\"source\":\"calling/callConnections/1a006780-0481-4472-a2b1-6d4535fbe7f9\",\"type\":\"Microsoft.Communication.CallDisconnected\",\"data\":{\"version\":\"2025-05-15\",\"resultInformation\":{\"code\":200,\"subCode\":7000,\"message\":\"The conversation has ended. DiagCode: 0#7000.@\"},\"callConnectionId\":\"1a006780-0481-4472-a2b1-6d4535fbe7f9\",\"serverCallId\":\"REDACTED\",\"correlationId\":\"bc5d7e7b-92f0-43f5-80c5-fe5a35ea40f8\",\"publicEventType\":\"Microsoft.Communication.CallDisconnected\"},\"time\":\"2025-05-22T17:25:21.9042843\\u002B00:00\",\"specversion\":\"1.0\",\"datacontenttype\":\"application/json\",\"subject\":\"calling/callConnections/1a006780-0481-4472-a2b1-6d4535fbe7f9\"}]"]
Loading
Loading