Skip to content

ThinClient E2E Integration #44854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 15, 2025
Merged

ThinClient E2E Integration #44854

merged 8 commits into from
Apr 15, 2025

Conversation

@nehrao1
Copy link
Member

@nehrao1 nehrao1 commented Apr 1, 2025 •
edited
Loading

Description

ThinClient E2E integration flow. Same changes as - #43790 - separated these changes out on to a fresh branch.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@nehrao1 nehrao1 requested review from a team and kirankumarkolli as code owners April 1, 2025 20:41
@github-actions github-actions bot added the Cosmos label Apr 1, 2025
@azure-sdk
Copy link
Collaborator

azure-sdk commented Apr 1, 2025

API change check

API changes are not detected in this pull request.

@nehrao1
Copy link
Member Author

nehrao1 commented Apr 3, 2025

/azp run java - cosmos - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 3, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@nehrao1
Copy link
Member Author

nehrao1 commented Apr 8, 2025

/azp run java - cosmos - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 8, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@nehrao1
Copy link
Member Author

nehrao1 commented Apr 12, 2025

/azp run java - cosmos - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 12, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@nehrao1
Copy link
Member Author

nehrao1 commented Apr 14, 2025

/azp run java - cosmos - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 14, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@nehrao1
Copy link
Member Author

nehrao1 commented Apr 14, 2025

/azp run java - cosmos - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 14, 2025

Azure Pipelines successfully started running 1 pipeline(s).

jeet1995
jeet1995 approved these changes Apr 14, 2025
View reviewed changes
Copy link
Member

@jeet1995 jeet1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks! Left some minor comments.

@nehrao1
Copy link
Member Author

nehrao1 commented Apr 14, 2025

/azp run java - cosmos - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 14, 2025

Azure Pipelines successfully started running 1 pipeline(s).

FabianMeiswinkel
FabianMeiswinkel reviewed Apr 15, 2025
View reviewed changes
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks

FabianMeiswinkel
FabianMeiswinkel approved these changes Apr 15, 2025
View reviewed changes
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks

@nehrao1
Copy link
Member Author

nehrao1 commented Apr 15, 2025

Only thin client live test stage failing now - appears to be purely network issue based on logs, agent keeps timing out trying to access gateway endpoint. Overriding

@nehrao1
Copy link
Member Author

nehrao1 commented Apr 15, 2025

/check-enforcer override

@nehrao1 nehrao1 merged commit 668d00c into Azure:main Apr 15, 2025
79 of 81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tvaron3 tvaron3 tvaron3 left review comments

@jeet1995 jeet1995 jeet1995 approved these changes

@FabianMeiswinkel FabianMeiswinkel FabianMeiswinkel approved these changes

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli kirankumarkolli is a code owner

Assignees

No one assigned

Labels

Cosmos

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nehrao1 @azure-sdk @jeet1995 @FabianMeiswinkel @tvaron3