Blob Create Snapshot Returns a Client #4472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* SAS implementation * Fixed some minor formatting issues * Fixed checkstyle problems and test issue
Removes RawClients from Storage Blobs
…construct clients
alzimmermsft
added
Client
alzimmermsft
requested review from
jaschrep-msft,
rickle-msft and
sima-zhu
as code owners
jaschrep-msft
requested changes
Jul 31, 2019
Member
jaschrep-msft
left a comment
jaschrep-msft
left a comment
There was a problem hiding this comment.
Why are account SAS changes in this PR?
We need to be able to get specialized blob clients for snapshots, as there are blob-type-specific APIs that don't modify. Right now, we only let this functionality get us BlobClient and BlobAsyncClient, and we'd have to pull the snapshot id out and manually construct the specific one. I guess we don't technically need this for append blobs, but I feel we should add that anyway for consistency.
sima-zhu
reviewed
Aug 2, 2019
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/BlobAsyncClient.java
Show resolved
Hide resolved
sima-zhu
reviewed
Aug 2, 2019
sdk/storage/azure-storage-blob/src/test/java/com/azure/storage/blob/SASTest.groovy
Outdated
Show resolved
Hide resolved
sima-zhu
reviewed
Aug 2, 2019
sdk/storage/azure-storage-blob/src/test/java/com/azure/storage/blob/SASTest.groovy
Outdated
Show resolved
Hide resolved
jaschrep-msft
approved these changes
Aug 2, 2019
srnagar
pushed a commit
to srnagar/azure-sdk-for-java
that referenced
this pull request
Aug 5, 2019
* Removed raw clients * Added deleteContainer to StorageClient * Merged Blob client builders into BlobClientBuilder * Storage SAS implementation (Azure#4404) * SAS implementation * Fixed some minor formatting issues * Fixed checkstyle problems and test issue * Remove RawClients from Blobs (Azure#4375) Removes RawClients from Storage Blobs * Added getAppendBlob with snapshot to ContainerClient * Updated Storage and Container clients to use AzureBlobStorageImpl to construct clients * Updating unit tests * Fix a snapshot test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4453
createSnapshot in Storage Blobs returns a new BlobClient that is used to interact with the snapshot that was created. Convenience method was added to create a new client by passing a snapshot instead of needing to create a new builder and configuring it.