Remove storage parent pom #4345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Storage blob needs to be included as a module in https://github.com/Azure/azure-sdk-for-java/blob/master/pom.client.xml#L741 |
Contributor
Author
|
@JonathanGiles We cannot pass the spotbugs check currently. Alan is working on spotbugs and checkstyle. We can add our module after his clean up. |
JonathanGiles
approved these changes
Jul 9, 2019
Contributor
Author
|
Alan will work on updating the blob pom file. I will work on the file and queue pom file in our feature branch. |
alzimmermsft
approved these changes
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The blob, file, queue will point to pom.client.xml directly.
Update the blob pom after Alan clean up the blob. #4346