Move keyvault #4340
Merged
Move keyvault #4340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/azp run java - keyvault - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
JonathanGiles
left a comment
JonathanGiles
left a comment
There was a problem hiding this comment.
Looks good. The /sdk/keyvault readme.md file is no longer accurate and needs updating to reflect track one and track two.
g2vinay
approved these changes
Jul 9, 2019
Member
|
README of keys and secrets will need updates of samples location URL. |
Contributor
Author
|
/azp run azure-sdk-for-java - client |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@g2vinay done. |
Member
|
My PR may finish before yours: #4344 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the KeyVault track 2 libraries to the sdk folder. These new modules sit alongside the track 1 libraries and so the pom.xml from track 2 has been renamed to pom.client.xml to disambiguate. Our optimizes PR pipelines build both track 1 and track 2 libraries currently but eventually we'll remove the track 1 libraries from the build once we decide we aren't maintaining them.
I also added reference to the core library to our pom.service.xml aggregator to overcome the fact that the updated version of core isn't published to maven central yet.