Skip to content

Add a missing sanitizer #39384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
billwert merged 2 commits into from
Mar 26, 2024
Merged

Add a missing sanitizer #39384

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e79fb46
Add a missing sanitizer
billwert Mar 23, 2024
306f276
apply spotless fix
billwert Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/core/azure-core-test/assets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "java",
"TagPrefix": "java/core/azure-core-test",
"Tag": "java/core/azure-core-test_7e6e34fcb0"
"Tag": "java/core/azure-core-test_60793a10db"
}
3 changes: 2 additions & 1 deletion sdk/core/azure-core-test/src/main/java/com/azure/core/test/http/TestProxyTestServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ public class TestProxyTestServer implements Closeable {

private static final String TEST_JSON_RESPONSE_BODY = "{\"modelId\":\"0cd2728b-210e-4c05-b706-f70554276bcc\","
+ "\"createdDateTime\":\"2022-08-31T00:00:00Z\",\"apiVersion\":\"2022-08-31\","
+ " \"accountKey\" : \"secret_account_key\"}";
+ " \"accountKey\" : \"secret_account_key\","
+ " \"client_secret\" : \"secret_client_secret\"}";
private static final String TEST_XML_RESPONSE_BODY = "{\"Body\":\"<UserDelegationKey>"
+ "<SignedTid>sensitiveInformation=</SignedTid></UserDelegationKey>\",\"primaryKey\":"
+ "\"<PrimaryKey>fakePrimaryKey</PrimaryKey>\", \"TableName\":\"listtable09bf2a3d\"}";
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/azure-core-test/src/main/java/com/azure/core/test/utils/TestProxyUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public class TestProxyUtils {

private static final List<String> JSON_PROPERTIES_TO_REDACT
= new ArrayList<>(Arrays.asList("authHeader", "accountKey", "accessToken", "accountName", "applicationId",
"apiKey", "connectionString", "url", "host", "password", "userName"));
"apiKey", "client_secret", "connectionString", "url", "host", "password", "userName"));

private static final Map<String, String> HEADER_KEY_REGEX_TO_REDACT = new HashMap<String, String>() {
{
Expand Down
1 change: 1 addition & 0 deletions sdk/core/azure-core-test/src/test/java/com/azure/core/test/TestProxyTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,7 @@ public void testRecordWithRedaction() {
.startsWith("https://REDACTED/fr/models//905a58f9-131e-42b8-8410-493ab1517d62"));
// custom sanitizers
assertEquals(REDACTED, record.getResponse().get("modelId"));
assertEquals(REDACTED, record.getResponse().get("client_secret"));
}
}

Expand Down