Skip to content

Cleanup azure-xml APIs#39320

Merged
alzimmermsft merged 3 commits intoAzure:mainfrom
alzimmermsft:AzXml_Cleanup
Mar 20, 2024
Merged

Cleanup azure-xml APIs#39320
alzimmermsft merged 3 commits intoAzure:mainfrom
alzimmermsft:AzXml_Cleanup

Conversation

@alzimmermsft
Copy link
Member

Description

Cleans up some APIs in azure-xml.

Removes the service provider interface and replaces it with direct (using factory methods) creation of XmlReader and XmlWriter. And provides the ability to pass the backing XMLStreamReader and XMLStreamWriter for more advanced use cases.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@alzimmermsft alzimmermsft self-assigned this Mar 20, 2024
@github-actions github-actions bot added the Azure.Core azure-core label Mar 20, 2024
Copy link
Member

@srnagar srnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alzimmermsft alzimmermsft marked this pull request as ready for review March 20, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure.Core azure-core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants