Fix for broker scenario #39284
Merged
Fix for broker scenario #39284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottaddie
reviewed
Mar 19, 2024
g2vinay
reviewed
Mar 20, 2024
...roker/src/main/java/com/azure/identity/broker/InteractiveBrowserBrokerCredentialBuilder.java
Outdated
Show resolved
Hide resolved
g2vinay
reviewed
Mar 20, 2024
sdk/identity/azure-identity/src/main/java/com/azure/identity/implementation/IdentityClient.java
Outdated
Show resolved
Hide resolved
In the case where the user requests signing in with the default account, fall back to the UI if it doesn't get one.
Co-authored-by: Scott Addie <[email protected]>
Co-authored-by: Scott Addie <[email protected]>
billwert
force-pushed
the
identity-fix-wam-default-fallback
branch
from
fad7cda to
4b1a304
Compare
sdk/identity/azure-identity/src/main/java/com/azure/identity/implementation/IdentityClient.java
Outdated
Show resolved
Hide resolved
sdk/identity/azure-identity/src/main/java/com/azure/identity/implementation/IdentityClient.java
Show resolved
Hide resolved
sdk/identity/azure-identity/src/main/java/com/azure/identity/implementation/IdentityClient.java
Outdated
Show resolved
Hide resolved
sdk/identity/azure-identity/src/main/java/com/azure/identity/implementation/IdentityClient.java
Show resolved
Hide resolved
g2vinay
reviewed
Mar 22, 2024
g2vinay
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case where the user requests signing in with the default account, fall back to the UI if it doesn't get one.
Also rename the API to align with current thinking