-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Fix DeleteOptions on Public Ip Address (issue#38806) #39096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6352b54 to
06af125
Compare
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
dd1cb79 to
150d4dd
Compare
2a3b5ad to
4b01e62
Compare
82d7443 to
045ce63
Compare
...ork/src/main/java/com/azure/resourcemanager/network/implementation/NetworkInterfaceImpl.java
Outdated
Show resolved
Hide resolved
...ork/src/main/java/com/azure/resourcemanager/network/implementation/NetworkInterfaceImpl.java
Outdated
Show resolved
Hide resolved
f382baa to
a055f07
Compare
a986b50 to
ef5e94b
Compare
|
Candidate API design. // create
// primary
.withPrimaryPublicIPAddressDeleteOptions(..)
// secondary
.defineSecondaryIPConfiguration(name)
.withDeleteOptions(..)
.attach()
// update
.withPrimaryPublicIPAddressDeleteOptions(..)
.defineSecondaryIPConfiguration(name)
.withDeleteOptions(..)
.attach()
// above part is same as create
// update DeleteOptions on existing nic configuration
.updateSecondaryIPConfiguration()
.withDeleteOptions(..)
.update()Having We seem not having |
Fix DeleteOptions on Public Ip Address (issue#38806 NetworkInterface fix only)
...network/src/test/java/com/azure/resourcemanager/network/NetworkInterfaceOperationsTests.java
Outdated
Show resolved
Hide resolved
9b1fb98 to
c45ef75
Compare
ddf9517 to
efbb9da
Compare
...manager-network/src/main/java/com/azure/resourcemanager/network/models/NetworkInterface.java
Outdated
Show resolved
Hide resolved
...nager-network/src/main/java/com/azure/resourcemanager/network/models/NicIpConfiguration.java
Outdated
Show resolved
Hide resolved
...network/src/test/java/com/azure/resourcemanager/network/NetworkInterfaceOperationsTests.java
Outdated
Show resolved
Hide resolved
...network/src/test/java/com/azure/resourcemanager/network/NetworkInterfaceOperationsTests.java
Outdated
Show resolved
Hide resolved
...network/src/test/java/com/azure/resourcemanager/network/NetworkInterfaceOperationsTests.java
Outdated
Show resolved
Hide resolved
...network/src/test/java/com/azure/resourcemanager/network/NetworkInterfaceOperationsTests.java
Outdated
Show resolved
Hide resolved
...network/src/test/java/com/azure/resourcemanager/network/NetworkInterfaceOperationsTests.java
Show resolved
Hide resolved
...network/src/test/java/com/azure/resourcemanager/network/NetworkInterfaceOperationsTests.java
Show resolved
Hide resolved
...network/src/test/java/com/azure/resourcemanager/network/NetworkInterfaceOperationsTests.java
Show resolved
Hide resolved
...k/src/main/java/com/azure/resourcemanager/network/implementation/NicIpConfigurationImpl.java
Show resolved
Hide resolved
7d4aef3 to
60192b2
Compare
2696524 to
84e8bf9
Compare
XiaofeiCao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@weidongxu-microsoft @haolingdong-msft for feedback as well
XiaofeiCao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also include changelog
...ork/src/main/java/com/azure/resourcemanager/network/implementation/NetworkInterfaceImpl.java
Outdated
Show resolved
Hide resolved
3317746 to
2028b72
Compare
b5b7ba2 to
9bc5f62
Compare
weidongxu-microsoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please arrange a follow-up PR to add a test case similar to this
https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/resourcemanager/azure-resourcemanager-compute/src/test/java/com/azure/resourcemanager/compute/VirtualMachineOperationsTests.java#L1018-L1072
Use creatable NetworkInterface from here, so that IP address can also be deleted.
relate to issue#38806
Fixed files:
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines