Add AACS GA JAVA SDK#37626
Merged
mengaims merged 58 commits intoAzure:mainfrom Nov 29, 2023
zhaiyutong:yutongzhai/add-acs-convenient
Merged
Add AACS GA JAVA SDK#37626mengaims merged 58 commits intoAzure:mainfrom zhaiyutong:yutongzhai/add-acs-convenient
mengaims merged 58 commits intoAzure:mainfrom
zhaiyutong:yutongzhai/add-acs-convenient
Conversation
Merge 22603c97054b46bc32729e274f459f0e6267824c into 89260be1a92c914b7b48af8e8f75938d5e76851d
zhaiyutong
requested review from
JonathanGiles,
anuchandy,
conniey,
joshfree,
lmolkova and
srnagar
as code owners
zhaiyutong
requested review from
ArthurMa1978,
JimSuplizio,
XiaofeiCao,
alzimmermsft,
g2vinay,
haolingdong-msft,
samvaity and
weidongxu-microsoft
as code owners
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
...ai-contentsafety/src/main/java/com/azure/ai/contentsafety/models/ContentSafetyImageData.java
Outdated
Show resolved
Hide resolved
Member
|
Analyze CI currently fails due to merge of an incorrect PR #37621. I've contacted the author to fix. |
Merge 570de777401fab039adb0a2a326ba51850028700 into 90a65cb3135d42438a381eb8bb5461a2b99b199f
Member
Author
…aiyutong/azure-sdk-for-java into yutongzhai/add-acs-convenient
| products: | ||
| - azure | ||
| - azure-cognitive-services | ||
| - azure-cognitive-services |
Member
There was a problem hiding this comment.
remember to change this line after Azure/azure-sdk-tools#7346 merged.
Member
There was a problem hiding this comment.
@zhaiyutong FYI you should be good with azure-ai-content-safety here since that is how the product is registered. I dont believe the product needs to match the SDK package name exactly.
| ``` | ||
|
|
||
| #### Create a ContentSafetyClient with Microsoft Entra ID (formerly Azure Active Directory (AAD)) token credential | ||
| - Step 1: Enable AAD for your resource |
Member
There was a problem hiding this comment.
Maybe rename AAD to Microsoft Entra ID in your content as well?
| As an example, [DefaultAzureCredential](https://github.com/Azure/azure-sdk-for-java/tree/main/sdk/identity/azure-identity#authenticate-with-defaultazurecredential) | ||
| can be used to authenticate the client. | ||
|
|
||
| DefaultAzureCredential will use the values from these environment variables. |
Member
There was a problem hiding this comment.
Suggested change
| DefaultAzureCredential will use the values from these environment variables. | |
| `DefaultAzureCredential` will use the values from these environment variables. |
mengaims
approved these changes
Nov 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines