Azure Defender EASM Public Preview#36282
Conversation
shadahmed-microsoft
requested review from
JonathanGiles,
anuchandy,
conniey,
joshfree,
lmolkova and
srnagar
as code owners
joshfree
added
the
Client
| The examples below require a Microsoft Defender EASM Resource and a corresponding authorized client. | ||
|
|
||
| Example of initializing a client: | ||
| ```java com.azure.resourcemanager.defendereasm.readme |
There was a problem hiding this comment.
The tags should not use com.azure.resourcemanager. resourcemanager is for management libraries only.
| ## Troubleshooting | ||
|
|
||
| ## Next steps | ||
|
|
There was a problem hiding this comment.
These two sections should not be empty.
| <dependency> | ||
| <groupId>com.azure</groupId> | ||
| <artifactId>azure-core</artifactId> | ||
| <version>1.41.0</version> <!-- {x-version-update;com.azure:azure-core;dependency} --> |
There was a problem hiding this comment.
These dependencies should be updated to latest released versions.
| <scope>test</scope> | ||
| </dependency> | ||
| </dependencies> | ||
| <build> |
There was a problem hiding this comment.
build section should not be included here. It will be derived from the parent pom.
| <project xmlns="http://maven.apache.org/POM/4.0.0" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
|
|
||
| <groupId>com.azure</groupId> |
There was a problem hiding this comment.
Parent pom reference is missing. Please add the parent pom as shown here.
| @@ -0,0 +1,13 @@ | |||
| # Release History | |||
There was a problem hiding this comment.
The directory name should match the artifact id. This should be in sdk/easm/azure-analytics-defender-easm/ directory.
|
|
||
| /** The AlexaInfo model. */ | ||
| @Immutable | ||
| public final class AlexaInfo { |
There was a problem hiding this comment.
Change the type name to AlexaDetails.
| <packaging>pom</packaging> | ||
| <version>1.0.0</version><!-- Need not change for every release--> | ||
|
|
||
| <modules> |
There was a problem hiding this comment.
We should update the root pom too as this PR is adding a new directory in sdk/.
| <version>1.0.0</version><!-- Need not change for every release--> | ||
|
|
||
| <modules> | ||
| <module>azure-analytics-defendereasm</module> |
There was a problem hiding this comment.
the module name should be azure-analytics-defender-easm.
| xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
| <groupId>com.azure</groupId> | ||
| <artifactId>azure-analytics-defendereasm</artifactId> |
There was a problem hiding this comment.
This should be named azure-easm-service
|
You can ref to the automated PR in your spec PR for guide on the changes (e.g. root pom, version_client.txt, tsp-location.yaml, etc.) Do use the correct package name and namespace. https://github.com/Azure/azure-rest-api-specs/pull/24937/files#r1325291737 |
|
@weidongxu-microsoft @srnagar , shad is no longer working for Microsoft, so I'm taking over this PR this sprint. I'm currently not having the permissions to push to this PR. Is it possible for me to get permission to push my changes here? Or is it advised to clone the repo and create another PR to replace this PR instead? Thank you |
|
@thang-bit You should have permissions now. Can you please verify? If this doesn't work, you should just create a new PR as the previous account may not be active and won't allow further updates to the PR. |
|
Closing this PR in favor of #37034 |
5 participants
Description
The SDK for Defender EASM Public Preview
product documentation
introductory session ticket
Typespec PR: Azure/azure-rest-api-specs#24937
arcboard: Azure/azure-sdk#5062
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines