Azcore cleanup httppipeline apis#3619
Merged
alzimmermsft merged 15 commits intoAzure:masterfrom May 17, 2019
Merged
Conversation
Contributor
|
Can one of the admins verify this patch? |
sima-zhu
reviewed
May 14, 2019
core/azure-core/src/main/java/com/azure/core/http/HttpPipeline.java
Outdated
Show resolved
Hide resolved
Member
|
@jianghaolu Keen to hear your thoughts on this PR. |
JonathanGiles
approved these changes
May 16, 2019
| * This class provides a fluent builder API to help aid the configuration and instantiation of the {@link HttpPipeline}, | ||
| * calling {@link HttpPipelineBuilder#build() build} constructs an instance of the pipeline. | ||
| * | ||
| * <pre> |
Member
There was a problem hiding this comment.
Add header here about code samples, and some explanation text.
core/azure-core/src/main/java/com/azure/core/http/HttpPipelineBuilder.java
Outdated
Show resolved
Hide resolved
core/azure-core/src/main/java/com/azure/core/http/HttpPipelineBuilder.java
Outdated
Show resolved
Hide resolved
core/azure-core/src/main/java/com/azure/core/http/HttpPipelineBuilder.java
Show resolved
Hide resolved
core/azure-core/src/test/java/com/azure/core/http/policy/HostPolicyTests.java
Outdated
Show resolved
Hide resolved
jianghaolu
approved these changes
May 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3608