Merged
Conversation
mssfang
added
Service Bus
Client
Contributor
|
Can one of the admins verify this patch? |
yvgopal
reviewed
May 15, 2019
| static int SUPPORTED_SAS_KEY_LENGTH = 44; | ||
| static String FIXED_CLAIM_TYPE = "SharedAccessKey"; | ||
| static int supportedSasKeyLength = 44; | ||
| static String fixedClaimType = "SharedAccessKey"; |
Member
There was a problem hiding this comment.
change them to final and keep all caps.
added 3 commits
May 16, 2019 11:32
…into ServiceBus-CheckStyle-5
…into ServiceBus-CheckStyle-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR contains only CheckStyle errors and warning fixes.