Skip to content

Comments

ServiceBus: CheckStyle Part 6#3574

Merged
mssfang merged 5 commits intoAzure:masterfrom
mssfang:ServiceBus-CheckStyle-6
May 17, 2019
Merged

ServiceBus: CheckStyle Part 6#3574
mssfang merged 5 commits intoAzure:masterfrom
mssfang:ServiceBus-CheckStyle-6

Conversation

@mssfang
Copy link
Contributor

@mssfang mssfang commented May 7, 2019

PR contains only CheckStyle errors and warning fixes.

  • no new line for bracket
  • spacing
  • using lambda function
  • modifier ordering: final static to static final
  • smaller first letter of method name in test class
  • delete redundant public modifier of constructor in package private class

@mssfang mssfang added Service Bus Client This issue points to a problem in the data-plane of the library. labels May 7, 2019
@mssfang mssfang requested review from conniey and yvgopal May 7, 2019 17:57
@mssfang mssfang self-assigned this May 7, 2019
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

TRACE_LOGGER.warn(errorMessage);
AsyncUtil.completeFutureExceptionally(MessagingFactory.this.connetionCloseFuture, new TimeoutException(errorMessage));
}
Timer.schedule(() -> {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using lambda function

Copy link
Member

@yvgopal yvgopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mssfang mssfang merged commit b8d8e93 into Azure:master May 17, 2019
@mssfang mssfang deleted the ServiceBus-CheckStyle-6 branch May 17, 2019 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client This issue points to a problem in the data-plane of the library. Service Bus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants