Merged
Conversation
mssfang
added
Service Bus
Client
Contributor
|
Can one of the admins verify this patch? |
mssfang
commented
May 7, 2019
|
|
||
| @Test | ||
| public void NullBinaryDataTest() { | ||
| public void nullBinaryDataTest() { |
Contributor
Author
There was a problem hiding this comment.
Even though the class and method are public, but it is a test class. It should not be a code-breaking change. Same to rest of methods in the class
conniey
reviewed
May 8, 2019
...ata-plane/azure-servicebus/src/test/java/com/microsoft/azure/servicebus/ManagementTests.java
Show resolved
Hide resolved
conniey
approved these changes
May 8, 2019
azure-sdk
pushed a commit
to openapi-env-test/azure-sdk-for-java
that referenced
this pull request
Aug 15, 2022
Dw/test label6 (Azure#3571) * Adding S360 fixes already made to newer API * Prettier run * ss Co-authored-by: Joseph Porter <josephporter@microsoft.com> Co-authored-by: Wei Dong <weidong@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR only contains Checkstyle errors and warnings:
These changes are straightforward