Skip to content

Comments

ServiceBus: CheckStyle Part 2#3567

Merged
mssfang merged 5 commits intoAzure:masterfrom
mssfang:ServiceBus-CheckStyle-2
May 16, 2019
Merged

ServiceBus: CheckStyle Part 2#3567
mssfang merged 5 commits intoAzure:masterfrom
mssfang:ServiceBus-CheckStyle-2

Conversation

@mssfang
Copy link
Contributor

@mssfang mssfang commented May 7, 2019

PR includes CheckStyle Errors and Warnings:

(1) Indentation
(2) Modifier Orderinf
(3) Redundant public modifer for package-private class
(4) no import *
(5) Using L for end of long instead of a small case of L

@mssfang mssfang added Service Bus Client This issue points to a problem in the data-plane of the library. labels May 7, 2019
@mssfang mssfang requested review from conniey and yvgopal May 7, 2019 01:01
@mssfang mssfang self-assigned this May 7, 2019
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?


private MessageBody() {}
private MessageBody() {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This extra line is unnecessary i believe. having the } on a new line is sufficient.

Copy link
Member

@conniey conniey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Small nit.

Copy link
Member

@yvgopal yvgopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mssfang mssfang merged commit b040468 into Azure:master May 16, 2019
@mssfang mssfang deleted the ServiceBus-CheckStyle-2 branch May 16, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client This issue points to a problem in the data-plane of the library. Service Bus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants