Skip to content

Comments

ServiceBus: CheckStyle Part 1 #3565

Merged
mssfang merged 8 commits intoAzure:masterfrom
mssfang:ServiceBus-CheckStyle-1
May 16, 2019
Merged

ServiceBus: CheckStyle Part 1 #3565
mssfang merged 8 commits intoAzure:masterfrom
mssfang:ServiceBus-CheckStyle-1

Conversation

@mssfang
Copy link
Contributor

@mssfang mssfang commented May 7, 2019

PR includes only Checkstyles warning and errors.

(1) no new line for openning bracket
(2) By default, the interface's method has public accessibility.

@mssfang mssfang added Service Bus Client This issue points to a problem in the data-plane of the library. labels May 7, 2019
@mssfang mssfang requested review from conniey and yvgopal May 7, 2019 00:05
@mssfang mssfang self-assigned this May 7, 2019
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@mssfang mssfang changed the title Service Bus: CheckStyle part 1 ServiceBus: CheckStyle Part 1 May 7, 2019
Copy link
Member

@conniey conniey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Copy link
Member

@yvgopal yvgopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mssfang mssfang merged commit a03bc60 into Azure:master May 16, 2019
@mssfang mssfang deleted the ServiceBus-CheckStyle-1 branch May 23, 2019 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client This issue points to a problem in the data-plane of the library. Service Bus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants