mgmt, update appplatform to 2022-12-01#35553
Merged
XiaofeiCao merged 7 commits intoAzure:mainfrom Jun 25, 2023
Merged
Conversation
XiaofeiCao
commented
Jun 21, 2023
Comment on lines
161
to
162
|
|
||
| /** | ||
| * Set the fqdn property: Fully qualified dns Name. | ||
| * | ||
| * @param fqdn the fqdn value to set. | ||
| * @return the AppResourceProperties object itself. | ||
| */ | ||
| public AppResourceProperties withFqdn(String fqdn) { | ||
| this.fqdn = fqdn; | ||
| return this; | ||
| } | ||
|
|
||
| /** |
Contributor
Author
There was a problem hiding this comment.
revapi.skip here. fqdn has changed to readOnly. We haven't expose this model from our public interface except innerModel().
Contributor
Author
There was a problem hiding this comment.
According to service, it's a swagger fix. This property is never allowed to change by user.
https://github.com/Azure/sdk-release-request/issues/4225#issuecomment-1605867112
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
XiaofeiCao
requested review from
ArthurMa1978,
haolingdong-msft and
weidongxu-microsoft
as code owners
weidongxu-microsoft
approved these changes
Jun 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
No manual code, live tests pass.
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines