Skip to content

Comments

mgmt compute, update api-version to 2022-08-01#31074

Merged
XiaofeiCao merged 8 commits intoAzure:mainfrom
XiaofeiCao:mgmt_compute_2022_08
Sep 23, 2022
Merged

mgmt compute, update api-version to 2022-08-01#31074
XiaofeiCao merged 8 commits intoAzure:mainfrom
XiaofeiCao:mgmt_compute_2022_08

Conversation

@XiaofeiCao
Copy link
Contributor

@XiaofeiCao XiaofeiCao commented Sep 21, 2022

Description

Fix https://github.com/Azure/sdk-release-request/issues/3205.
No manual code, live tests pass.

Breaking change discussed and approved in Azure/azure-rest-api-specs#20097 (comment).

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@XiaofeiCao XiaofeiCao added Mgmt This issue is related to a management-plane library. Mgmt - Track 2 labels Sep 21, 2022
@XiaofeiCao XiaofeiCao self-assigned this Sep 21, 2022
@azure-sdk
Copy link
Collaborator

azure-sdk commented Sep 21, 2022

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-resourcemanager-compute

@XiaofeiCao
Copy link
Contributor Author

Public IP addresses with basic skus can no longer be created with zone resiliency. https://github.com/Azure/sdk-release-request/issues/3205#issuecomment-1254413032

Will wait for service justification.

@XiaofeiCao
Copy link
Contributor Author

XiaofeiCao commented Sep 22, 2022

It's a behavioral change from Network RP. I'll investigate whether it's introduced by new network version.

For now, I think we can change the implicitly created pip sku to standard if zone resiliency is enabled on vm.

### Bugs Fixed

### Other Changes
- Since `2021-05-01`, `PublicIpAddress` of `Basic` Sku no longer supported configuring with Availability Zone.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also give our version 2.1x

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

Copy link
Member

@haolingdong-msft haolingdong-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. May need to add back add-opens to make LIVE and RECORD tests pass.

@XiaofeiCao
Copy link
Contributor Author

LGTM. May need to add back add-opens to make LIVE and RECORD tests pass.

Added.

@XiaofeiCao XiaofeiCao merged commit 9453084 into Azure:main Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt - Track 2 Mgmt This issue is related to a management-plane library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants