[CommunicationIdentifier] Added setter for rawId#30240
Merged
Conversation
iaulakh
requested review from
a team,
JianpingChen,
ankitarorabit and
minnieliu
as code owners
ghost
added
the
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
DominikMe
reviewed
Aug 2, 2022
Member
DominikMe
left a comment
DominikMe
left a comment
There was a problem hiding this comment.
Thanks Inderpal! Added comments to protected where applicable
...mmunication-common/src/main/java/com/azure/communication/common/CommunicationIdentifier.java
Outdated
Show resolved
Hide resolved
...ication-common/src/main/java/com/azure/communication/common/CommunicationUserIdentifier.java
Outdated
Show resolved
Hide resolved
| * @return UnknownIdentifier object itself | ||
| */ | ||
| @Override | ||
| public UnknownIdentifier setRawId(String rawId) { |
Member
There was a problem hiding this comment.
Suggested change
| public UnknownIdentifier setRawId(String rawId) { | |
| protected UnknownIdentifier setRawId(String rawId) { |
petrsvihlik
approved these changes
Aug 3, 2022
petrsvihlik
previously requested changes
Aug 3, 2022
...ure-communication-common/src/main/java/com/azure/communication/common/UnknownIdentifier.java
Outdated
Show resolved
Hide resolved
DominikMe
requested changes
Aug 3, 2022
Member
DominikMe
left a comment
DominikMe
left a comment
There was a problem hiding this comment.
Lgtm after making UnknownIdentifier.setRawId protected again
DominikMe
approved these changes
Aug 3, 2022
DominikMe
dismissed
petrsvihlik’s stale review
Discussed offline, will follow up as needed.
DominikMe
deleted the
communication-identifier-raw-id-translation-revision
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolving ARB feedback of PR #28997
ARB -> https://apiview.dev/Assemblies/Review/c236ca96fddc4b00a242f80eb58a1a0d?diffRevisionId=f8cf7a20da7643ada4f46109b8ab6f96&doc=False&diffOnly=False&revisionId=1659814d80124d0b8348367fad4e4f7c
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines