Skip to content

Fix protocol policy test #29706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samvaity merged 2 commits into from
Jun 29, 2022
Merged

Fix protocol policy test #29706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d20fcc
un-static request
samvaity Jun 29, 2022
94f0128
same change, requestId
samvaity Jun 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 4 additions & 14 deletions sdk/core/azure-core/src/test/java/com/azure/core/http/policy/ProtocolPolicyTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,31 +18,21 @@
import static org.junit.jupiter.api.Assertions.assertEquals;

public class ProtocolPolicyTests {
static final HttpRequest HTTP_REQUEST;

static {
try {
HTTP_REQUEST = createHttpRequest("https://www.bing.com");
} catch (MalformedURLException e) {
throw new RuntimeException(e);
}
}

@SyncAsyncTest
public void withOverwrite() throws Exception {
final HttpPipeline pipeline = createPipeline("ftp", "ftp://www.bing.com");
SyncAsyncExtension.execute(
() -> pipeline.sendSync(HTTP_REQUEST, Context.NONE),
() -> pipeline.send(HTTP_REQUEST)
() -> pipeline.sendSync(createHttpRequest("https://www.bing.com"), Context.NONE),
() -> pipeline.send(createHttpRequest("https://www.bing.com"))
);
}

@SyncAsyncTest
public void withNoOverwrite() throws Exception {
final HttpPipeline pipeline = createPipeline("ftp", false, "https://www.bing.com");
SyncAsyncExtension.execute(
() -> pipeline.sendSync(HTTP_REQUEST, Context.NONE),
() -> pipeline.send(HTTP_REQUEST)
() -> pipeline.sendSync(createHttpRequest("https://www.bing.com"), Context.NONE),
() -> pipeline.send(createHttpRequest("https://www.bing.com"))
);
}

Expand Down
17 changes: 4 additions & 13 deletions sdk/core/azure-core/src/test/java/com/azure/core/http/policy/RequestIdPolicyTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,6 @@
import java.time.temporal.ChronoUnit;

public class RequestIdPolicyTests {
static final HttpRequest HTTP_REQUEST;

static {
try {
HTTP_REQUEST = createHttpRequest("https://www.bing.com");
} catch (MalformedURLException e) {
throw new RuntimeException(e);
}
}

private final HttpResponse mockResponse = new HttpResponse(null) {
@Override
Expand Down Expand Up @@ -98,8 +89,8 @@ public Mono<HttpResponse> send(HttpRequest request) {
.build();

SyncAsyncExtension.execute(
() -> pipeline.sendSync(HTTP_REQUEST, Context.NONE),
() -> pipeline.send(HTTP_REQUEST)
() -> pipeline.sendSync(createHttpRequest("https://www.bing.com"), Context.NONE),
() -> pipeline.send(createHttpRequest("https://www.bing.com"))
);
}

Expand Down Expand Up @@ -127,8 +118,8 @@ public Mono<HttpResponse> send(HttpRequest request) {
.build();

SyncAsyncExtension.execute(
() -> pipeline.sendSync(HTTP_REQUEST, Context.NONE),
() -> pipeline.send(HTTP_REQUEST)
() -> pipeline.sendSync(createHttpRequest("https://www.bing.com"), Context.NONE),
() -> pipeline.send(createHttpRequest("https://www.bing.com"))
);
}

Expand Down