Added encryption option to perf tests#29703
Merged
rickle-msft merged 2 commits intoAzure:mainfrom Jun 30, 2022
Merged
Conversation
rickle-msft
requested review from
alzimmermsft,
ibrahimrabab,
jaschrep-msft and
kasobol-msft
as code owners
ghost
added
the
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
| public class BlobPerfStressOptions extends StoragePerfStressOptions { | ||
|
|
||
| @Parameter(names = { "--encryption-version" }) | ||
| private String encryptionVersion; |
Contributor
There was a problem hiding this comment.
this can be enum, JCommander should be able to parse it.
See
for reference.
Make sure to default to null.
kasobol-msft
approved these changes
Jun 30, 2022
kasobol-msft
added a commit
that referenced
this pull request
Jul 5, 2022
This reverts commit 8d85737.
mssfang
pushed a commit
to mssfang/azure-sdk-for-java
that referenced
this pull request
Jul 6, 2022
This reverts commit 8d85737.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.