Skip to content

Sample showing handling of terminal error from ServiceBusReceiverAsyncClient while streaming messages#29702

Merged
anuchandy merged 1 commit intoAzure:mainfrom
anuchandy:lowlevel-receiver-recovery-sample
Jun 29, 2022
Merged

Sample showing handling of terminal error from ServiceBusReceiverAsyncClient while streaming messages#29702
anuchandy merged 1 commit intoAzure:mainfrom
anuchandy:lowlevel-receiver-recovery-sample

Conversation

@anuchandy
Copy link
Member

No description provided.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@anuchandy anuchandy enabled auto-merge (squash) June 29, 2022 19:34
Copy link
Member

@conniey conniey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add to our samples/README.md.
LGTM.

Comment on lines +24 to +25
* The sample demonstrates how handle terminal error from {@link ServiceBusReceiverAsyncClient} (aka LowLevelClient)
* and recreate the LowLevelClient to continue receive.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* The sample demonstrates how handle terminal error from {@link ServiceBusReceiverAsyncClient} (aka LowLevelClient)
* and recreate the LowLevelClient to continue receive.
* The sample demonstrates how to handle a terminal error from {@link ServiceBusReceiverAsyncClient#receiveMessages()}
* and recreate the client to continue receiving messages.

@@ -0,0 +1,311 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add link to our samples/README.md.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @conniey, both feedback addressed in the new pr #29704

@anuchandy anuchandy merged commit 741fa23 into Azure:main Jun 29, 2022
anuchandy added a commit to anuchandy/azure-sdk-for-java that referenced this pull request Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants