Refactor move servicebus message state key to azure-core-amqp#29309
Refactor move servicebus message state key to azure-core-amqp#29309ZejiaJiang merged 5 commits intoAzure:mainfrom
Conversation
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
|
you might need to wait after servicebus June release (amqp released, but servicebus is not yet). |
|
I think servicebus is released, you might want to refresh main and get it merged before next code freeze. |
| /** | ||
| * The state of message. | ||
| */ | ||
| SERVICE_BUS_MESSAGE_STATE_ANNOTATION_NAME("x-opt-message-state"); |
There was a problem hiding this comment.
Any reason for why we change the name from SERVICE_BUS_MESSAGE_STATE_KEY to SERVICE_BUS_MESSAGE_STATE_ANNOTATION_NAME?
Since we move it into amqp, is it ok to remove SERVICE_BUS prefix?
There was a problem hiding this comment.
Yeah, the above keys have ANNOTATION_NAME suffix as well and we do get the key from annotation.
I'll check these keys usage and remove the prefix.
JimSuplizio
left a comment
There was a problem hiding this comment.
The creation and use of the unreleased_ tag was done correctly and I'm okay with those changes. I'll let the other people review and approve the corresponding code changes.
Description
Refactor: move servicebus message state key to
azure-core-amqpconstants. #26898All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines