Live tests #2812
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| resources: | ||
| - repo: self | ||
| queue: | ||
| name: Hosted VS2017 | ||
| steps: | ||
| - bash: | | ||
|
Member
There was a problem hiding this comment. Is there a reason you aren't using the Maven@3 task to run the tests similar to https://github.com/Azure/azure-sdk-for-java/blob/master/.azure-pipelines/client.test.yml#L17? In general we should try to do that to help be consistent and also that allows us to capture the test results into the test tab of the build which gives us a good view of the tests than ran and a history of them.
Member
Author
There was a problem hiding this comment. The environment variables were not read during the build when tried to configure as Maven task. |
||
| LOG_PARAMS='-Dorg.slf4j.simpleLogger.defaultLogLevel=error -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn' | ||
| mvn test -Dsurefire.rerunFailingTestsCount=3 $LOG_PARAMS -Dparallel=classes -DthreadCount=3 -DforkCount=1C -f pom.client.build.xml | ||
| displayName: 'Bash Script' | ||
|
Member
There was a problem hiding this comment. Please update this to represent what it is doing, like "Running Live Tests" |
||
| env: | ||
| ARM_CLIENTID: $(ARM_CLIENTID) | ||
|
Member
There was a problem hiding this comment. Are these 2 env variables the only difference between live vs not live?
Member
Author
There was a problem hiding this comment. There are more Variables defined in the variables tab of dev ops pipeline. |
||
| ARM_CLIENTKEY: $(ARM_CLIENTKEY) | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,38 +1,38 @@ | ||
| <?xml version="1.0"?> | ||
| <!DOCTYPE Configure PUBLIC "-//Jetty//Configure//EN" "http://www.eclipse.org/jetty/configure_9_0.dtd"> | ||
| <Configure id="Server" class="org.eclipse.jetty.server.Server"> | ||
| <Call name="addConnector"> | ||
| <Arg> | ||
| <New class="org.eclipse.jetty.server.ServerConnector"> | ||
| <Arg name="server"> | ||
| <Ref refid="Server" /> | ||
| </Arg> | ||
| <Arg name="factories"> | ||
| <Array type="org.eclipse.jetty.server.ConnectionFactory"> | ||
| <Item> | ||
| <New class="org.eclipse.jetty.server.HttpConnectionFactory"/> | ||
| </Item> | ||
| </Array> | ||
| </Arg> | ||
| <Set name="port">11080</Set> | ||
| </New> | ||
| </Arg> | ||
| </Call> | ||
| <Call name="addConnector"> | ||
| <Arg> | ||
| <New class="org.eclipse.jetty.server.ServerConnector"> | ||
| <Arg name="server"> | ||
| <Ref refid="Server" /> | ||
| </Arg> | ||
| <Arg name="factories"> | ||
| <Array type="org.eclipse.jetty.server.ConnectionFactory"> | ||
| <Item> | ||
| <New class="org.eclipse.jetty.server.HttpConnectionFactory"/> | ||
| </Item> | ||
| </Array> | ||
| </Arg> | ||
| <Set name="port">11081</Set> | ||
| </New> | ||
| </Arg> | ||
| </Call> | ||
| </Configure> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,6 @@ | |
| import com.microsoft.aad.adal4j.AuthenticationResult; | ||
| import com.microsoft.aad.adal4j.ClientCredential; | ||
| import com.microsoft.azure.AzureResponseBuilder; | ||
| import com.microsoft.azure.keyvault.KeyVaultClient; | ||
| import com.microsoft.azure.keyvault.authentication.KeyVaultCredentials; | ||
| import com.microsoft.azure.keyvault.models.Attributes; | ||
|
|
@@ -78,11 +77,11 @@ public static String getSecondaryVaultUri() { | |
| } | ||
|
|
||
| private static String getLiveVaultUri1() { | ||
| return getenvOrDefault("KEYVAULT_VAULTURI", "https://javasdktestvault.vault.azure.net"); | ||
|
Member
There was a problem hiding this comment. Out of curiosity - what motivated the changing of all key names to uppercase with underscores rather that periods?
Contributor
There was a problem hiding this comment. Looks like periods are not processed correctly on linux system, and VSTS converts them to underscore, and converts environment variable names to uppercase anyway. Please see https://developercommunity.visualstudio.com/content/problem/328064/vsts-silently-converts-variable-names-to-uppercase.html for uppercase and https://stackoverflow.com/questions/50020314/escaping-environment-variable-names-in-vsts for underscores. |
||
| } | ||
|
|
||
| private static String getLiveVaultUri2() { | ||
| return getenvOrDefault("KEYVAULT_VAULTURI_ALT", "https://javasdktestvault2.vault.azure.net"); | ||
| } | ||
|
|
||
| private static String getenvOrDefault(String varName, String defValue) { | ||
|
|
@@ -100,13 +99,13 @@ protected static void compareAttributes(Attributes expectedAttributes, Attribute | |
|
|
||
| private static AuthenticationResult getAccessToken(String authorization, String resource) throws Exception { | ||
|
|
||
| String clientId = System.getenv("ARM_CLIENTID"); | ||
|
|
||
| if (clientId == null) { | ||
| throw new Exception("Please inform arm.clientid in the environment settings."); | ||
| } | ||
|
|
||
| String clientKey = System.getenv("ARM_CLIENTKEY"); | ||
| String username = System.getenv("arm.username"); | ||
| String password = System.getenv("arm.password"); | ||
|
|
||
|
|
@@ -351,7 +350,7 @@ protected static DeletedKeyBundle pollOnKeyDeletion(String vaultBaseUrl, String | |
|
|
||
| protected static DeletedSecretBundle pollOnSecretDeletion(String vaultBaseUrl, String secretName) throws Exception { | ||
| int pendingPollCount = 0; | ||
| while (pendingPollCount < 70) { | ||
| DeletedSecretBundle deletedSecretBundle = keyVaultClient.getDeletedSecret(vaultBaseUrl, secretName); | ||
| if (deletedSecretBundle == null) { | ||
| if (isRecordMode()) { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need "resources: self"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed actually,
removed.