Skip to content

Schema Registry: Update support for 415 error code. Regenerate test playback files.#25342

Merged
conniey merged 8 commits intoAzure:mainfrom
conniey:schema-registry/415
Nov 11, 2021
Merged

Schema Registry: Update support for 415 error code. Regenerate test playback files.#25342
conniey merged 8 commits intoAzure:mainfrom
conniey:schema-registry/415

Conversation

@conniey
Copy link
Copy Markdown
Member

@conniey conniey commented Nov 11, 2021

Description

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@conniey conniey added Client This issue points to a problem in the data-plane of the library. Schema Registry labels Nov 11, 2021
@conniey conniey self-assigned this Nov 11, 2021
@PathParam("schemaName") String schemaName,
@QueryParam("api-version") String apiVersion,
@BodyParam("application/json; serialization=avro") String schemaContent,
@BodyParam("application/json; serialization=Avro") String schemaContent,
Copy link
Copy Markdown

@lmolkova lmolkova Nov 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for my own education: if this is eventually ends up in the HTTP content-type header, why does the case (avro -> Avro) matter?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't. I can remove it to reduce the diff

@conniey conniey merged commit 252afe9 into Azure:main Nov 11, 2021
@conniey conniey deleted the schema-registry/415 branch November 11, 2021 21:26
XiaofeiCao pushed a commit to XiaofeiCao/azure-sdk-for-java that referenced this pull request Nov 18, 2021
…layback files. (Azure#25342)

* Fix user agent string.

* Adding new record playback files.

* Adding regenerated classes.

* Adding additional tests.

* Adding content headers depending on SchemaFormat type.

* Adding CHANGELOG.md

* Update sdk/schemaregistry/azure-data-schemaregistry/CHANGELOG.md

Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client This issue points to a problem in the data-plane of the library. Schema Registry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants