Schema Registry: Update support for 415 error code. Regenerate test playback files.#25342
Merged
conniey merged 8 commits intoAzure:mainfrom Nov 11, 2021
Merged
Schema Registry: Update support for 415 error code. Regenerate test playback files.#25342conniey merged 8 commits intoAzure:mainfrom
conniey merged 8 commits intoAzure:mainfrom
Conversation
lmolkova
approved these changes
Nov 11, 2021
| @PathParam("schemaName") String schemaName, | ||
| @QueryParam("api-version") String apiVersion, | ||
| @BodyParam("application/json; serialization=avro") String schemaContent, | ||
| @BodyParam("application/json; serialization=Avro") String schemaContent, |
There was a problem hiding this comment.
for my own education: if this is eventually ends up in the HTTP content-type header, why does the case (avro -> Avro) matter?
Member
Author
There was a problem hiding this comment.
It doesn't. I can remove it to reduce the diff
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
XiaofeiCao
pushed a commit
to XiaofeiCao/azure-sdk-for-java
that referenced
this pull request
Nov 18, 2021
…layback files. (Azure#25342) * Fix user agent string. * Adding new record playback files. * Adding regenerated classes. * Adding additional tests. * Adding content headers depending on SchemaFormat type. * Adding CHANGELOG.md * Update sdk/schemaregistry/azure-data-schemaregistry/CHANGELOG.md Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines