Fixing encryption create with contentResponseOnWriteEnabled false#23218
Merged
simplynaveen20 merged 3 commits intoAzure:mainfrom Jul 29, 2021
Merged
Conversation
simplynaveen20
requested review from
FabianMeiswinkel,
aayush3011,
kirankumarkolli,
kushagraThapar,
mbhaskar,
milismsft,
moderakh and
xinlian12
as code owners
ghost
added
the
moderakh
approved these changes
Jul 28, 2021
Contributor
moderakh
left a comment
moderakh
left a comment
There was a problem hiding this comment.
LGTM. some minor comments.
Thanks.
...encryption/src/main/java/com/azure/cosmos/encryption/implementation/EncryptionProcessor.java
Outdated
Show resolved
Hide resolved
...-cosmos-encryption/src/test/java/com/azure/cosmos/encryption/EncryptionAsyncApiCrudTest.java
Outdated
Show resolved
Hide resolved
kushagraThapar
approved these changes
Jul 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we are getting below exception on createItem as code is trying to decrypt the data for null response when contentResponseOnWriteEnabled is false(default), this PR will fix it.