[Storage] jumbo blobs stress tests. #23119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Contributor
Author
|
/azp run java - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run java - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run java - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run java - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run java - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run java - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run java - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run java - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run java - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run java - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kasobol-msft
requested review from
JonathanGiles,
amishra-dev,
benbp,
jaschrep-msft,
mssfang and
rickle-msft
as code owners
gapra-msft
reviewed
Jul 22, 2021
| */ | ||
| public static final int BUFFER_COPY_LENGTH = 8 * KB; | ||
|
|
||
| public static final int MAX_INPUT_STREAM_CONVERTER_BUFFER_LENGTH = 64 * MB; |
Member
There was a problem hiding this comment.
How did we come to this value? Should we add some documentation explaining why we need to do this?
Contributor
Author
There was a problem hiding this comment.
- We know that allocating Int.MAX leads to
java.lang.OutOfMemoryError: Requested array size exceeds VM limit(there are plenty of articles about it). - Allocating big arrays isn't great - they put more pressure on GC if heap is fragmented and it's lesser chance of allocating one.
- The value is guestimated based on few experiments. I.e. for jumbo blobs going to low means too much extra garbage to just wrap arrays into buffers.
gapra-msft
approved these changes
Jul 22, 2021
alzimmermsft
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
java.lang.OutOfMemoryError: Requested array size exceeds VM limit