Add support for the perf library for ACR. #23118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pallavit
force-pushed
the
pallavit/addPerfLib
branch
from
7b52325 to
521b748
Compare
pallavit
requested review from
JimSuplizio,
alzimmermsft,
benbp,
danieljurek,
g2vinay,
jianghaolu and
samvaity
as code owners
alzimmermsft
approved these changes
Jul 21, 2021
| <dependency> | ||
| <groupId>com.azure</groupId> | ||
| <artifactId>azure-identity</artifactId> | ||
| <version>1.3.1</version> <!-- {x-version-update;com.azure:azure-identity;dependency} --> |
Member
There was a problem hiding this comment.
nit: this isn't the right version (1.3.3) #Resolved
| @@ -0,0 +1,102 @@ | |||
| package com.azure.containers.containerregistry.perf.core; | |||
Member
There was a problem hiding this comment.
Missing license header #Resolved
| @@ -0,0 +1,18 @@ | |||
| package com.azure.containers.containerregistry.perf.core; | |||
Member
There was a problem hiding this comment.
Missing license header #Resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the ACR perf library.