Add support for the tests on national cloud. #23117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pallavit
force-pushed
the
pallavit/acrcloudtests
branch
2 times, most recently
from
6b6a73b to
1649db1
Compare
pallavit
requested review from
alzimmermsft,
benbp and
jianghaolu
as code owners
...est/java/com/azure/containers/containerregistry/ContainerRepositoryAnonymousAccessTests.java
Outdated
Show resolved
Hide resolved
Comment on lines
190
to
196
| if (getTestMode() != TestMode.PLAYBACK) { | ||
| // Now doing the same should fail with the separate registryClient; | ||
| ContainerRegistryClient throwableRegistryClient = getContainerRegistryBuilder(httpClient) | ||
| .authenticationScope(AZURE_GOV_AUTHENTICATION_SCOPE) | ||
| .buildClient(); | ||
| assertThrows(ClientAuthenticationException.class, () -> throwableRegistryClient.listRepositoryNames().stream().collect(Collectors.toList())); | ||
| } |
Member
There was a problem hiding this comment.
Should this be made into a separate test that has an assumption of TestMode != PLAYBACK #Resolved
...est/java/com/azure/containers/containerregistry/ContainerRepositoryAnonymousAccessTests.java
Outdated
Show resolved
Hide resolved
pallavit
force-pushed
the
pallavit/acrcloudtests
branch
2 times, most recently
from
74f9a25 to
6900985
Compare
pallavit
force-pushed
the
pallavit/acrcloudtests
branch
from
6900985 to
ede9b7a
Compare
alzimmermsft
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ACR tests to work with national cloud(s). I have also added a manual weekly pipeline that runs it against USGov, China.