create Subscription Rule with CorrelationFilter does not create respect properties #22556
Conversation
… does not create respect properties
ghost
added
Service Bus
customer-reported
|
Thank you for your contribution hongli750210! We will review the pull request and get back to you soon. |
|
All test cases in [ServiceBusSessionManagerTest] can be successfully executed in environments such as [Test ubuntu2004_111_TestFromSource_surefiretest], so execute the test again in [Test ubuntu2004_111_surefiretest]. |
v-hongli1
requested review from
YijunXieMS,
conniey,
hemanttanwar and
yvgopal
as code owners
|
|
||
| private static final class PropertiesWrapper { | ||
| @JacksonXmlProperty(localName = "KeyValueOfstringanyType") | ||
| @JacksonXmlProperty(localName = "KeyValueOfstringanyType", namespace = "http://schemas.microsoft.com/netservices/2010/10/servicebus/connect") |
There was a problem hiding this comment.
This code is generated so we better not change it manually.
@jianghaolu, @srnagar, @alzimmermsft does the code gen customization support this customization?
There was a problem hiding this comment.
This should be do-able using a Swagger transform to add a namespace sub-property to the XML declaration of keyValueOfstringanyType.
There was a problem hiding this comment.
I agree, this should not be hand-edited. Also, updating the swagger might be useful if all other languages are also doing something similar.
There was a problem hiding this comment.
This setting is added to correspond to the problem that the namespace attribute of the KeyValueOfstringanyType in the XML is a blank value. If this problem can be corrected through swagger, please inform the location of the swagger configuration file storage.
There was a problem hiding this comment.
@alzimmermsft The swagger already has namespace property. But the generated code doesn't have it.
https://github.com/Azure/azure-rest-api-specs/blob/39ffff91d145f6c8f7ec1a6ae46bda17256e8d2e/specification/servicebus/data-plane/servicebus-swagger.json#L1513
"KeyValue": {
"description": "Key Values of custom properties",
"type": "object",
"xml": {
"name": "KeyValueOfstringanyType",
"namespace": "http://schemas.microsoft.com/netservices/2010/10/servicebus/connect"
},
"properties": {
"key": {
"type": "string",
"xml": {
"name": "Key",
"namespace": "http://schemas.microsoft.com/netservices/2010/10/servicebus/connect"
}
},
"value": {
"type": "string",
"xml": {
"name": "Value",
"namespace": "http://schemas.microsoft.com/netservices/2010/10/servicebus/connect"
}
}
}
},There was a problem hiding this comment.
@srnagar, @jianghaolu, @weidongxu-microsoft, could this be an code generation issue when there is a combination of XML wrapped and namespace attribute, where the namespace attribute doesn't get propagated to the wrapped property?
There was a problem hiding this comment.
Yes, this is a codegen issue. It's missing the namespace when generating the internal wrapper classes. I'll have this fixed.
.../main/java/com/azure/messaging/servicebus/implementation/ServiceBusManagementSerializer.java
Outdated
Show resolved
Hide resolved
…lationFilter does not create respect properties 20210628 by lihong
YijunXieMS
left a comment
YijunXieMS
left a comment
There was a problem hiding this comment.
Let's manually edit the namespace for now and investigate why generated code doesn't have the namespace later.
|
@hongli750210, @YijunXieMS, before this PR is merged, do these locations need to be fixed as well: |
Good catch Alan. They should be fixed as well. @hongli750210 |
…lationFilter does not create respect properties 2021063010220 by lihong
|
@YijunXieMS |
4 participants
@jongio, @YijunXieMS for notification