Skip to content

Conversation

@simplynaveen20
Copy link
Member

This PR contains

  1. Adding gated test for client telemetry service validation
    (Juno stage endpoint will be available via environment variable added in tests.yml as cosmos-client-telemetry-endpoint
    whose value is coming from our TestSecrets-Cosmos key vault)

  2. Adding our default httptimeout for client telemetry request

  3. refactored the package to remove camel case from package name com.azure.cosmos.implementation.clientTelemetry -> com.azure.cosmos.implementation.clienttelemetry.

- template: ../../eng/pipelines/templates/variables/globals.yml
- name: AdditionalArgs
value: ''
value: '-DCOSMOS.CLIENT_TELEMETRY_ENDPOINT=$(cosmos-client-telemetry-endpoint)'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benbp as discussed added the environment variable

Copy link
Contributor

@moderakh moderakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@simplynaveen20
Copy link
Member Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@simplynaveen20
Copy link
Member Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@simplynaveen20
Copy link
Member Author

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@kushagraThapar kushagraThapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplynaveen20
Copy link
Member Author

/check-enforcer override

@simplynaveen20 simplynaveen20 merged commit fba3194 into Azure:main Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants