Closing reactor executor when IO pipe is closed.#22192
Merged
Conversation
conniey
requested review from
JimSuplizio,
JonathanGiles,
alzimmermsft,
anuchandy,
danieljurek,
g2vinay,
hemanttanwar,
jianghaolu,
lmolkova,
mitchdenny,
mssfang,
samvaity,
schaabs and
srnagar
as code owners
conniey
force-pushed
the
conniey/close-executor
branch
from
c498aa1 to
c117dca
Compare
YijunXieMS
approved these changes
Jun 10, 2021
Contributor
YijunXieMS
left a comment
YijunXieMS
left a comment
There was a problem hiding this comment.
Verified with long running test. "reactor-executor" threads were cleaned when "IO Sink was interrupted".
conniey
added a commit
to conniey/azure-sdk-for-java
that referenced
this pull request
Jun 10, 2021
* When IO sink is disposed of, close the corresponding executor. * Update ReactorExecutor to use AsyncCloseable. * Removing unused method. * Add changelog entry.
conniey
added a commit
that referenced
this pull request
Jun 10, 2021
* Fix Management Bug (#22122) * Adding missing return statement. * Using common logic for status codes. * Adding isSuccessful. * Closing reactor executor when IO pipe is closed. (#22192) * When IO sink is disposed of, close the corresponding executor. * Update ReactorExecutor to use AsyncCloseable. * Removing unused method. * Add changelog entry. * Fix Azure Core Amqp Sample issue #18806 by lihong 202105271344 (#21885) * Running prepare-release script. Co-authored-by: Hong Li(MSFT) <74638143+hongli750210@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.