Skip to content

Made Tables service interfaces public #22130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vcolin7 merged 4 commits into from
Jun 8, 2021
Merged

Made Tables service interfaces public #22130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8db222a
Made service interfaces public for Key Vault and Tables impl clients.
vcolin7 Jun 8, 2021
aaaa93f
Removed kvErrorStrings.properties files from Key Vault SDKs. Made Key…
vcolin7 Jun 8, 2021
164b340
Added check for null credentials in Key Vault Administration Builders.
vcolin7 Jun 8, 2021
3f39386
Reverted changes made to KV libraries.
vcolin7 Jun 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...data-tables/src/main/java/com/azure/data/tables/implementation/AzureTableImplBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
import com.azure.core.util.Configuration;
import com.azure.core.util.serializer.JacksonAdapter;
import com.azure.core.util.serializer.SerializerAdapter;

import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
Expand Down
3 changes: 1 addition & 2 deletions ...bles/azure-data-tables/src/main/java/com/azure/data/tables/implementation/TablesImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,9 @@
import com.azure.data.tables.implementation.models.TablesQueryResponse;
import com.azure.data.tables.implementation.models.TablesSetAccessPolicyResponse;
import com.azure.data.tables.implementation.models.TablesUpdateEntityResponse;
import reactor.core.publisher.Mono;

import java.util.List;
import java.util.Map;
import reactor.core.publisher.Mono;

/** An instance of this class provides access to all the operations defined in Tables. */
public final class TablesImpl {
Expand Down
2 changes: 1 addition & 1 deletion ...ata-tables/src/main/java/com/azure/data/tables/implementation/TransactionalBatchImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public TransactionalBatchImpl(AzureTableImpl client, SerializerAdapter transacti
*/
@Host("{url}")
@ServiceInterface(name = "AzureTableServices")
private interface TransactionalBatchService {
public interface TransactionalBatchService {
Copy link
Member

@alzimmermsft alzimmermsft Jun 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this done by hand or was there an update to the Swagger configurations? If the former this will be overwritten every time the client is regenerated.

Copy link
Member Author

@vcolin7 vcolin7 Jun 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was done by hand because this particular interface was also written by hand. The others were already being generated with public due to the swagger markdown file being configured as such.

@Post("/$batch")
@ExpectedResponses({202})
@UnexpectedResponseExceptionType(TableServiceErrorException.class)
Expand Down