Skip to content

Update datafeed tests to remove error code asserts #22121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samvaity merged 1 commit into from
Jun 8, 2021
Merged

Update datafeed tests to remove error code asserts #22121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions sdk/metricsadvisor/azure-ai-metricsadvisor/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,24 @@
# Release History

## 1.0.0-beta.4 (Unreleased)
## 1.0.0-beta.4 (2021-03-08)

### Features added
- Added support for Azure Log Analytics DataFeed source
- Added data source credential API support to client
- Added authentication type support for data feed
- Added property `splitAlertByDimensions` to AnomalyAlertConfiguration model
- Added `clientOptions()` methods to the `MetricsAdvisorClientBuilder` and `MetricsAdvisorAdministrationClientBuilder`

### Breaking changes
- Replaced updateSubscriptionKey and updateApiKey into one method updateKey
- Deprecated support for HttpRequestDataFeed and ElasticsearchDataFeed source type
- Removed granularity type DataFeedGranularityType.PerSecond as it's not supported by the service anymore
- Renamed `value` and `expectedValue` to `valueOfRootNode` and `expectedValueOfRootNode`
- Renamed `top` parameter to `maxPageSize`
- Removed granularity type DataFeedGranularityType.PerSecond as it's not supported by the service anymore.

- Renamed method `listAnomaliesForAlert` and `listAnomaliesForDetectionConfig` to `listAnomalies`
- Renamed method `listIncidentsForAlert` and `listIncidentsForDetectionConfig` to `listIncidents`
- Renamed `ErrorCodeException` and `ErrorCode` to `MetricsAdvisorResponseException` and `MetricsAdvisorError`

## 1.0.0-beta.3 (2021-02-09)
- Support Azure Active Directory (AAD) authentication for Metrics Advisor clients.
- Renamed method `listDimensionValuesWithAnomalies` and `ListDimensionValuesWithAnomaliesOptions`.
Expand Down
1 change: 0 additions & 1 deletion ...-ai-metricsadvisor/src/test/java/com/azure/ai/metricsadvisor/DataFeedAsyncClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -736,7 +736,6 @@ public void deleteDataFeedIdWithResponse(HttpClient httpClient, MetricsAdvisorSe
.verifyErrorSatisfies(throwable -> {
assertEquals(MetricsAdvisorResponseException.class, throwable.getClass());
final MetricsAdvisorError errorCode = ((MetricsAdvisorResponseException) throwable).getValue();
assertEquals(errorCode.getCode(), "ERROR_INVALID_PARAMETER");
assertEquals(errorCode.getMessage(), "datafeedId is invalid.");
});
}, SQL_SERVER_DB);
Expand Down
1 change: 0 additions & 1 deletion ...azure-ai-metricsadvisor/src/test/java/com/azure/ai/metricsadvisor/DataFeedClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -728,7 +728,6 @@ public void deleteDataFeedIdWithResponse(HttpClient httpClient, MetricsAdvisorSe
MetricsAdvisorResponseException exception = assertThrows(MetricsAdvisorResponseException.class, () ->
client.getDataFeedWithResponse(createdDataFeed.getId(), Context.NONE));
final MetricsAdvisorError errorCode = exception.getValue();
assertEquals(errorCode.getCode(), "ERROR_INVALID_PARAMETER");
assertEquals(errorCode.getMessage(), "datafeedId is invalid.");
}, SQL_SERVER_DB);
}
Expand Down