Skip to content

Fix storage queues sample issues #21988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alzimmermsft merged 3 commits into from
Jul 21, 2021
Merged

Fix storage queues sample issues #21988

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
438339c
Fix Storage - Queues Sample issues
LuHang2021 May 31, 2021
44d528d
Fix Storage - Queues Sample issues
LuHang2021 May 31, 2021
c97737c
Restore the first modified sendMessage
LuHang2021 Jun 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...-storage-queue/src/samples/java/com/azure/storage/queue/QueueAsyncJavaDocCodeSamples.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ public void enqueueMessageAsync() {
*/
public void enqueueMessageBinaryDataAsync() {
// BEGIN: com.azure.storage.queue.queueAsyncClient.sendMessage#BinaryData
client.sendMessage(BinaryData.fromString("Hello, Azure")).subscribe(
client.sendMessage(BinaryData.fromString("Hello, Azure").toString()).subscribe(
Comment thread
LuHang2021 marked this conversation as resolved.
Outdated
response -> {
},
error -> System.err.print(error.toString()),
Expand Down Expand Up @@ -176,7 +176,7 @@ public void enqueueMessageAsyncWithTimeoutOverload() {
*/
public void enqueueMessageBinaryDataAsyncWithTimeoutOverload() {
// BEGIN: com.azure.storage.queue.queueAsyncClient.sendMessageWithResponse#BinaryData-duration-duration
client.sendMessageWithResponse(BinaryData.fromString("Hello, Azure"),
client.sendMessageWithResponse(BinaryData.fromString("Hello, Azure").toString(),
Duration.ofSeconds(5), null).subscribe(
response -> System.out.printf("Message %s expires at %s", response.getValue().getMessageId(),
response.getValue().getExpirationTime()),
Expand Down Expand Up @@ -208,7 +208,7 @@ public void enqueueMessageAsyncWithLiveTimeOverload() {
*/
public void enqueueMessageBinaryDataAsyncWithLiveTimeOverload() {
// BEGIN: com.azure.storage.queue.QueueAsyncClient.sendMessageWithResponse-liveTime#BinaryData-Duration-Duration
client.sendMessageWithResponse(BinaryData.fromString("Goodbye, Azure"),
client.sendMessageWithResponse(BinaryData.fromString("Hello, Azure").toString(),
null, Duration.ofSeconds(5)).subscribe(
response -> System.out.printf("Message %s expires at %s", response.getValue().getMessageId(),
response.getValue().getExpirationTime()),
Expand Down
6 changes: 3 additions & 3 deletions ...azure-storage-queue/src/samples/java/com/azure/storage/queue/QueueJavaDocCodeSamples.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ public void sendMessage() {
public void sendMessageBinaryData() {

// BEGIN: com.azure.storage.queue.queueClient.sendMessage#BinaryData
SendMessageResult response = client.sendMessage(BinaryData.fromString("hello msg"));
SendMessageResult response = client.sendMessage(BinaryData.fromString("Hello, Azure").toString());
System.out.println("Complete enqueuing the message with message Id" + response.getMessageId());
// END: com.azure.storage.queue.queueClient.sendMessage#BinaryData
}
Expand All @@ -239,7 +239,7 @@ public void enqueueMessageWithTimeoutOverload() {
public void enqueueMessageBinaryDataWithTimeoutOverload() {

// BEGIN: com.azure.storage.queue.QueueClient.sendMessageWithResponse#BinaryData-Duration-Duration-Duration-Context1
SendMessageResult sentMessageItem = client.sendMessageWithResponse(BinaryData.fromString("Hello, Azure"),
SendMessageResult sentMessageItem = client.sendMessageWithResponse(BinaryData.fromString("Hello, Azure").toString(),
Duration.ofSeconds(5), null, Duration.ofSeconds(1), new Context(key1, value1)).getValue();
System.out.printf("Message %s expires at %s", sentMessageItem.getMessageId(),
sentMessageItem.getExpirationTime());
Expand All @@ -265,7 +265,7 @@ public void sendMessageWithLiveTimeOverload() {
*/
public void sendMessageBinaryDataWithLiveTimeOverload() {
// BEGIN: com.azure.storage.queue.QueueClient.sendMessageWithResponse#BinaryData-Duration-Duration-Duration-Context2
SendMessageResult enqueuedMessage = client.sendMessageWithResponse(BinaryData.fromString("Goodbye, Azure"),
SendMessageResult enqueuedMessage = client.sendMessageWithResponse(BinaryData.fromString("Hello, Azure").toString(),
null, Duration.ofSeconds(5), Duration.ofSeconds(1), new Context(key1, value1)).getValue();
System.out.printf("Message %s expires at %s", enqueuedMessage.getMessageId(),
enqueuedMessage.getExpirationTime());
Expand Down
2 changes: 1 addition & 1 deletion sdk/storage/azure-storage-queue/src/samples/java/com/azure/storage/queue/ReadmeSamples.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ public void getQueueListInAccount() {
// @param options: Filter for queue selection
// @param timeout: An optional timeout applied to the operation.
// @param context: Additional context that is passed through the Http pipeline during the service call.
queueServiceClient.listQueues(markers, options, timeout, context).stream().forEach(queueItem -> {
queueServiceClient.listQueues(options, timeout, context).stream().forEach(queueItem -> {
System.out.printf("Queue %s exists in the account.", queueItem.getName());
});
}
Expand Down