Skip to content

Add Factory Method to SynonymMap to Create from File#20984

Merged
alzimmermsft merged 3 commits intoAzure:masterfrom
alzimmermsft:AzSearch_AddSynonymMapFromFileFactoryMethod
Apr 27, 2021
Merged

Add Factory Method to SynonymMap to Create from File#20984
alzimmermsft merged 3 commits intoAzure:masterfrom
alzimmermsft:AzSearch_AddSynonymMapFromFileFactoryMethod

Conversation

@alzimmermsft
Copy link
Member

Fixes #20329

This PR adds a factory method to SynonymMap to enable creating it from a given file.

@alzimmermsft alzimmermsft added Search Client This issue points to a problem in the data-plane of the library. labels Apr 27, 2021
@alzimmermsft alzimmermsft self-assigned this Apr 27, 2021
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@alzimmermsft
Copy link
Member Author

/azp run java - search - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@alzimmermsft alzimmermsft merged commit c4885be into Azure:master Apr 27, 2021
@alzimmermsft alzimmermsft deleted the AzSearch_AddSynonymMapFromFileFactoryMethod branch April 27, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client This issue points to a problem in the data-plane of the library. Search

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a Convenience Method to Create a SynonymMap from a File/Stream

2 participants