Skip to content

[Communication] - SMS - adding assertion to verify error code 401 #20933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paolamvhz merged 2 commits into from
Apr 23, 2021
Merged

[Communication] - SMS - adding assertion to verify error code 401 #20933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e1e75d
re adding assertion
paolamvhz Apr 23, 2021
1ceaf21
adding test record
paolamvhz Apr 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ...zure-communication-sms/src/test/java/com/azure/communication/sms/SmsAsyncClientTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,10 +150,8 @@ public void sendFromUnauthorizedNumber(HttpClient httpClient) {
// Action & Assert
Mono<SmsSendResult> response = asyncClient.send("+18007342577", TO_PHONE_NUMBER, MESSAGE);
StepVerifier.create(response)
.expectError().verify();
// TODO: re-enable this when service change is made
//.expectErrorMatches(exception ->
// ((HttpResponseException) exception).getResponse().getStatusCode() == 401).verify();
.expectErrorMatches(exception ->
((HttpResponseException) exception).getResponse().getStatusCode() == 401).verify();
}

@ParameterizedTest
Expand Down
3 changes: 1 addition & 2 deletions ...ion/azure-communication-sms/src/test/java/com/azure/communication/sms/SmsClientTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,7 @@ public void sendFromUnauthorizedNumber(HttpClient httpClient) {
SmsSendResult response = client.send("+18007342577", TO_PHONE_NUMBER, MESSAGE);
} catch (Exception exception) {
assertNotNull(((HttpResponseException) exception).getResponse().getStatusCode());
// TODO: re-enable this when service change is made
//assertEquals(401, ((HttpResponseException) exception).getResponse().getStatusCode());
assertEquals(401, ((HttpResponseException) exception).getResponse().getStatusCode());
}
}

Expand Down
14 changes: 7 additions & 7 deletions ...src/test/resources/session-records/SmsAsyncClientTests.sendFromUnauthorizedNumber[1].json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,18 @@
"Method" : "POST",
"Uri" : "https://REDACTED.communication.azure.com/sms?api-version=2021-03-07",
"Headers" : {
"User-Agent" : "azsdk-java-azure-communication-sms/1.0.0-beta.5 (11.0.8; Windows 10; 10.0)",
"User-Agent" : "azsdk-java-azure-communication-sms/1.0.1 (15.0.1; Windows 10; 10.0)",
"Content-Type" : "application/json"
},
"Response" : {
"content-length" : "0",
"api-supported-versions" : "2020-07-20-preview1, 2020-08-20-preview, 2021-03-07",
"X-Processing-Time" : "276ms",
"MS-CV" : "02V0pMyhYEqt9Ppq6IsUzg.0",
"X-Processing-Time" : "420ms",
"MS-CV" : "MF1HkLIYBEeDxppDAHatnQ.0",
"retry-after" : "0",
"X-Azure-Ref" : "0FX5CYAAAAAD59GhqbPjwSYIPbDxPd0ORWVZSMzBFREdFMDQwOAA5ZmM3YjUxOS1hOGNjLTRmODktOTM1ZS1jOTE0OGFlMDllODE=",
"Content-Length" : "0",
"StatusCode" : "404",
"Date" : "Fri, 05 Mar 2021 18:53:10 GMT",
"X-Azure-Ref" : "0jiKDYAAAAACgf/mlrIJUQrgSthlobIR6TEFYRURHRTEyMDkAOWZjN2I1MTktYThjYy00Zjg5LTkzNWUtYzkxNDhhZTA5ZTgx",
"StatusCode" : "401",
"Date" : "Fri, 23 Apr 2021 19:39:58 GMT",
"Request-Context" : "appId="
},
"Exception" : null
Expand Down
14 changes: 7 additions & 7 deletions ...-sms/src/test/resources/session-records/SmsClientTests.sendFromUnauthorizedNumber[1].json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,18 @@
"Method" : "POST",
"Uri" : "https://REDACTED.communication.azure.com/sms?api-version=2021-03-07",
"Headers" : {
"User-Agent" : "azsdk-java-azure-communication-sms/1.0.0-beta.5 (11.0.8; Windows 10; 10.0)",
"User-Agent" : "azsdk-java-azure-communication-sms/1.0.1 (15.0.1; Windows 10; 10.0)",
"Content-Type" : "application/json"
},
"Response" : {
"content-length" : "0",
"api-supported-versions" : "2020-07-20-preview1, 2020-08-20-preview, 2021-03-07",
"X-Processing-Time" : "279ms",
"MS-CV" : "y0RQshIEZ0eA/g8YUeD8NA.0",
"X-Processing-Time" : "488ms",
"MS-CV" : "x/jt7fsoXESjpWKGCbETWA.0",
"retry-after" : "0",
"X-Azure-Ref" : "0c35CYAAAAABHcM9dqJCESLz3NefWeYBnWVZSMzBFREdFMDQxNQA5ZmM3YjUxOS1hOGNjLTRmODktOTM1ZS1jOTE0OGFlMDllODE=",
"Content-Length" : "0",
"StatusCode" : "404",
"Date" : "Fri, 05 Mar 2021 18:54:42 GMT",
"X-Azure-Ref" : "0KyKDYAAAAADxdvccxwkeSrdhXYtsDPjNTEFYRURHRTEyMTEAOWZjN2I1MTktYThjYy00Zjg5LTkzNWUtYzkxNDhhZTA5ZTgx",
"StatusCode" : "401",
"Date" : "Fri, 23 Apr 2021 19:38:19 GMT",
"Request-Context" : "appId="
},
"Exception" : null
Expand Down