Skip to content

Conversation

@azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#1562 See eng/common workflow

- Update link checking pipeline to enable caching
- Add loading cache file from a http endpoint
- Add retry logic when hitting 429

Fix verify link renaming scenarios

- Correctly error if link format is incorrect
- Handle case where the replace regex is not passed
- Improve the error logging so it is easier to
  identify the broken links
@azure-sdk azure-sdk added Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system. labels Apr 22, 2021
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@azure-sdk azure-sdk merged commit 30a8778 into master Apr 22, 2021
@azure-sdk azure-sdk deleted the sync-eng/common-CachingSupport-1562 branch April 22, 2021 21:16
benbp pushed a commit that referenced this pull request Apr 28, 2021
- Update link checking pipeline to enable caching
- Add loading cache file from a http endpoint
- Add retry logic when hitting 429

Fix verify link renaming scenarios

- Correctly error if link format is incorrect
- Handle case where the replace regex is not passed
- Improve the error logging so it is easier to
  identify the broken links

Co-authored-by: Wes Haggard <[email protected]>
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Oct 12, 2022
add AVS 2022-05-01 API (Azure#20873)

* copy 2021-12-01

* replace api-version
and replace subscription-id in examples

* allow specifying a sku in Locations_CheckTrialAvailability

* add Clusters_ListZones

* add WorkloadNetworks_Get & WorkloadNetworks_List

* Arc Addons

* add readOnly nsxPublicIpQuotaRaised flag to PrivateCloudProperties

* add readonly autoDetectedKeyVersion to EncryptionKeyVaultProperties

* definition of WorkloadNetwork & WorkloadNetworkList

* add affinityStrength and azureHybridBenefitType to VmHostPlacementPolicyProperties

* add affinityStrength and azureHybridBenefitType to PlacementPolicyUpdateProperties

* add definitions for ClusterZone and ClusterZoneList

* add company and uri to ScriptPackageProperties

* add to readme

* add x-ms-identifiers

* suppress ParametersOrder

* fix Azure#20902. add Canceled to all provisioningState

* fix trial spelling

* add workloadNetworkName param to WorkloadNetworks_Get

* use v3/types in new operations
Clusters_ListZones, WorkloadNetworks_Get, WorkloadNetworks_List

* fix response type for WorkloadNetworks_List

* remove empty property bags

* add workloadNetworkName to WorkloadNetworks_Get example

* use suppressions

* restore AutoRest v2 Suppressions

* fix ConsistentPatchProperties by using PlacePolicy resource directly in PlacementPolicies_Update

* Revert "fix ConsistentPatchProperties by using PlacePolicy resource directly in PlacementPolicies_Update"

This reverts commit b88a2c064b31198844432c06142212ab8cd92d7d.

* suppress ConsistentPatchProperties

* suppress DefinitionsPropertiesNamesCamelCase & ArmResourcePropertiesBag

* suppress DeleteOperationAsyncResponseValidation

* add 202 responses to PrivateClouds_Update & Clusters_Update

* just warnings

* suppress PatchSkuProperty

* Revert "add 202 responses to PrivateClouds_Update & Clusters_Update"

This reverts commit 9d6abb129a92a5d018aef9997212ced1055d5352.

* suppress LroPatch202

* suppress UnSupportedPatchProperties `name` & `type`

* suppress XmsLongRunningOperationOptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants