Skip to content

Conversation

@zhichengliu12581
Copy link
Contributor

@zhichengliu12581 zhichengliu12581 commented Apr 19, 2021

add parameter to support refresh certificate when which have new version on portal
related issue: #20592

  • Add parameters to support users to refresh the certificate regularly
  • Add parameters to support users to obtain the latest certificate when they receive an untrusted certificate
  • Add method to enable users to obtain AzureKeyVault

@ghost ghost added KeyVault azure-spring All azure-spring related issues labels Apr 19, 2021
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@zhichengliu12581 zhichengliu12581 marked this pull request as ready for review April 20, 2021 04:47
@chenrujun chenrujun self-assigned this Apr 20, 2021
@chenrujun chenrujun added azure-spring-keyvault Spring keyvault related issues. Client This issue points to a problem in the data-plane of the library. labels Apr 20, 2021
@chenrujun chenrujun added this to the [2021] June milestone Apr 20, 2021
@chenrujun chenrujun linked an issue Apr 20, 2021 that may be closed by this pull request
@chenrujun chenrujun linked an issue May 24, 2021 that may be closed by this pull request
@yiliuTo
Copy link
Member

yiliuTo commented May 24, 2021

/azp run java - keyvault - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chenrujun
Copy link

/azp run java - keyvault - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chenrujun
Copy link

/azp run java - keyvault - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chenrujun
Copy link

/azp run java - keyvault - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chenrujun chenrujun linked an issue May 25, 2021 that may be closed by this pull request
@yiliuTo
Copy link
Member

yiliuTo commented May 25, 2021

/azp run java - keyvault - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yiliuTo
Copy link
Member

yiliuTo commented May 25, 2021

/azp run java - keyvault - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chenrujun
Copy link

/azp run java - keyvault - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chenrujun
Copy link

Closing this PR because all commits included in #21816

@chenrujun chenrujun closed this May 25, 2021
@zhichengliu12581 zhichengliu12581 deleted the add-key-vault-dynamic-refresh-parameter branch August 24, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azure-spring All azure-spring related issues azure-spring-keyvault Spring keyvault related issues. Client This issue points to a problem in the data-plane of the library. KeyVault

Projects

None yet

5 participants