-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Removed afterburner usage from Cosmos Exception #20114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed afterburner usage from Cosmos Exception #20114
Conversation
moderakh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kushagraThapar
LGTM.
FabianMeiswinkel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed offline - I would prefer also renaming Utils.getSimpleObjectMapper to something like Utils.getObjectMapperWithAfterBurner to avoid unintentional regressions in the future.
Otherwise LGTM
can we maybe call it |
xinlian12
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT, thanks for the fix Kushagra
|
@FabianMeiswinkel @moderakh - I have updated the name to The reason I didn't choose |
This reverts commit 4f109fa.
CosmosExceptionafter we converted the cosmos exception message into Json format in this PR : Converting cosmos exception into json format #18092 after release 4.11.0 and above.CosmosDiagnosticsdoesn't throw this warning, but when loggingCosmosException, the warning is thrown, becauseCosmosExceptionusesUtils.getSimpleObjectMapper()- which registers moduleAfterBurnerModule()There is no need to use this same ObjectMapper for
CosmosException, it can use its ownObjectMapperas used byCosmosDiagnostics,ClientSideRequestStatistics,ClientTelemetry,RntbdObjectMapperand so on.