[Communication] -SMS- adding new samples and fixing Readme#19708
Merged
paolamvhz merged 6 commits intoAzure:masterfrom Mar 9, 2021
Merged
[Communication] -SMS- adding new samples and fixing Readme#19708paolamvhz merged 6 commits intoAzure:masterfrom
paolamvhz merged 6 commits intoAzure:masterfrom
Conversation
paolamvhz
requested review from
a team,
JianpingChen,
ankitarorabit and
minnieliu
as code owners
ghost
added
the
minnieliu
reviewed
Mar 8, 2021
...ation-sms/src/samples/java/com/azure/communication/sms/samples/quickstart/ReadmeSamples.java
Outdated
Show resolved
Hide resolved
...ation-sms/src/samples/java/com/azure/communication/sms/samples/quickstart/ReadmeSamples.java
Outdated
Show resolved
Hide resolved
...ation-sms/src/samples/java/com/azure/communication/sms/samples/quickstart/ReadmeSamples.java
Outdated
Show resolved
Hide resolved
...ation-sms/src/samples/java/com/azure/communication/sms/samples/quickstart/ReadmeSamples.java
Outdated
Show resolved
Hide resolved
...ation-sms/src/samples/java/com/azure/communication/sms/samples/quickstart/ReadmeSamples.java
Outdated
Show resolved
Hide resolved
beltr0n
requested changes
Mar 8, 2021
...ation-sms/src/samples/java/com/azure/communication/sms/samples/quickstart/ReadmeSamples.java
Outdated
Show resolved
Hide resolved
...ation-sms/src/samples/java/com/azure/communication/sms/samples/quickstart/ReadmeSamples.java
Outdated
Show resolved
Hide resolved
...ation-sms/src/samples/java/com/azure/communication/sms/samples/quickstart/ReadmeSamples.java
Outdated
Show resolved
Hide resolved
minnieliu
reviewed
Mar 9, 2021
...ation-sms/src/samples/java/com/azure/communication/sms/samples/quickstart/ReadmeSamples.java
Outdated
Show resolved
Hide resolved
minnieliu
reviewed
Mar 9, 2021
...ation-sms/src/samples/java/com/azure/communication/sms/samples/quickstart/ReadmeSamples.java
Outdated
Show resolved
Hide resolved
minnieliu
requested changes
Mar 9, 2021
...ation-sms/src/samples/java/com/azure/communication/sms/samples/quickstart/ReadmeSamples.java
Outdated
Show resolved
Hide resolved
...ation-sms/src/samples/java/com/azure/communication/sms/samples/quickstart/ReadmeSamples.java
Outdated
Show resolved
Hide resolved
...ation-sms/src/samples/java/com/azure/communication/sms/samples/quickstart/ReadmeSamples.java
Outdated
Show resolved
Hide resolved
...ation-sms/src/samples/java/com/azure/communication/sms/samples/quickstart/ReadmeSamples.java
Outdated
Show resolved
Hide resolved
beltr0n
requested changes
Mar 9, 2021
...ation-sms/src/samples/java/com/azure/communication/sms/samples/quickstart/ReadmeSamples.java
Outdated
Show resolved
Hide resolved
...ation-sms/src/samples/java/com/azure/communication/sms/samples/quickstart/ReadmeSamples.java
Outdated
Show resolved
Hide resolved
minnieliu
reviewed
Mar 9, 2021
...ation-sms/src/samples/java/com/azure/communication/sms/samples/quickstart/ReadmeSamples.java
Outdated
Show resolved
Hide resolved
...ation-sms/src/samples/java/com/azure/communication/sms/samples/quickstart/ReadmeSamples.java
Outdated
Show resolved
Hide resolved
...ation-sms/src/samples/java/com/azure/communication/sms/samples/quickstart/ReadmeSamples.java
Outdated
Show resolved
Hide resolved
...ation-sms/src/samples/java/com/azure/communication/sms/samples/quickstart/ReadmeSamples.java
Outdated
Show resolved
Hide resolved
...ation-sms/src/samples/java/com/azure/communication/sms/samples/quickstart/ReadmeSamples.java
Outdated
Show resolved
Hide resolved
...ation-sms/src/samples/java/com/azure/communication/sms/samples/quickstart/ReadmeSamples.java
Outdated
Show resolved
Hide resolved
minnieliu
reviewed
Mar 9, 2021
...ation-sms/src/samples/java/com/azure/communication/sms/samples/quickstart/ReadmeSamples.java
Show resolved
Hide resolved
minnieliu
approved these changes
Mar 9, 2021
beltr0n
approved these changes
Mar 9, 2021
Member
beltr0n
left a comment
beltr0n
left a comment
There was a problem hiding this comment.
looks good, thanks for addressing the comments!
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
Jul 14, 2022
[Hub Generated] Publish private branch 'dev-devcenter-Microsoft.DevCenter-2022-08-01-preview_renamerp' (Azure#19708) * add or modify files * Including subsequent changes made in separate PR - https://github.com/Azure/azure-rest-api-specs-pr/pull/7688. 1) update environment creator role assignment in spec to match user role assignments. 2) add domainJoinType to attached network. * Fixed spellcheck failures. * Updated title to DevCenterClient to resolve sdk generation issues. * Fix RPaaS validation failure. Set 'final-state-via' property to 'location' for POST sync catalog operation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding new samples and fixing Readme