Conversation
YijunXieMS
added
Event Grid
Client
| <packaging>jar</packaging> | ||
|
|
||
| <properties> | ||
| <maven.compiler.target>11</maven.compiler.target> |
There was a problem hiding this comment.
Removed to inherit from parent
|
|
||
| @Override | ||
| public void run() { | ||
| eventGridEventPublisherClient.sendEventGridEvents(createEvents()); |
There was a problem hiding this comment.
The create Events method needs to be moved to setupAsync method or the constructor, store the events as a local Array List.
There was a problem hiding this comment.
I prefer calling createEvents for every send because it's more like user scenario, which send out different events for every call.
|
|
||
| @Override | ||
| public void run() { | ||
| cloudEventPublisherClient.sendCloudEvents(createEvents()); |
There was a problem hiding this comment.
The create Events method needs to be moved to setupAsync method or the constructor, store the events as a local Array List.
| protected final EventGridPublisherClient eventGridEventPublisherClient; | ||
| protected final EventGridPublisherAsyncClient eventGridEventPublisherAsyncClient; | ||
|
|
||
| public ServiceTest(TOptions options) { |
There was a problem hiding this comment.
Add some javadocs everywehre, just as best practice.
There was a problem hiding this comment.
Added javadocs (pretty simple though) to pass check style.
| SendCloudEventsTest.class, | ||
| SendEventGridEventsTest.class | ||
| }; | ||
|
|
There was a problem hiding this comment.
This section can be replaced with:
PerfStressProgram.run(new Class<?>[]{
SendCloudEventsTest.class,
SendEventGridEventsTest.class
}, args)
There was a problem hiding this comment.
Update as suggested.
YijunXieMS
requested review from
JimSuplizio,
alzimmermsft,
danieljurek,
mitchdenny and
samvaity
as code owners
|
@YijunXieMS @g2vinay Let's get this ready to merge and reviewed - it's a shame to see it not getting put to good use! :-) |
| List<EventGridEvent> events = new ArrayList<>(); | ||
| for (int i = 0; i < options.getCount(); i++) { | ||
| String dataPayload = String.join("", Collections.nCopies(options.getCount(), "A")); | ||
| EventGridEvent event = new EventGridEvent("https://www.eventgrid.com/", "EG.Perf", |
|
@srnagar can you help shepherd this PR in? |
|
@joshfree yes, I'll fix the merge conflicts, address comments and merge the PR. |
ghost
added
the
no-recent-activity
|
Hi @YijunXieMS. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
ghost
closed this
|
Hi @YijunXieMS. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass. |
[Hub Generated] Publish private branch 'appplatform/release/05-01-preview' (Azure#19057) * [AutoSync] bff534817 Merged PR 6051224: feat: add acis for lifecycle multi-version config * revert changes Co-authored-by: swagger-automation <swagger@microsoft.com> Co-authored-by: Xuyang Cao <xuycao@microsoft.com>
5 participants
No description provided.