-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Enhance aad it for on demand feature #18896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
...zure-spring-boot-test-aad/src/test/java/com/azure/test/aad/selenium/AADSeleniumITHelper.java
Outdated
Show resolved
Hide resolved
…into enhance-aad-IT-for-on-demand
|
/azp run java - spring - tests |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
/azp run java - spring - tests |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
chenrujun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
…into enhance-aad-IT-for-on-demand
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/check-enforcer override |
[Hub Generated] Review request for Microsoft.VirtualMachineImages to add version stable/2022-02-14 (Azure#18896) * Adds base for updating Microsoft.VirtualMachineImages from version stable/2021-10-01 to version 2022-02-14 * Updates readme * Updates API version in new specs and examples * adding 2022 changes * fixed proxy resource path * added object to ImageTemplate* * added object to valide and prettier to examples * added identifier * removed format integer 32 for breaking change * added back format integer 64, to be in compliance for lintdiff and breaking change * adding back int32 after getting jeffrey richters approval
This PR add a new IT for aad on-demand authorization feature.
Note that due to #18774 hasn't been merged yet, thus changes to create test user are on tests.yml and don't involve Azure China tests. This will be improved after that PR is merged.