Skip to content

Conversation

@yiliuTo
Copy link
Member

@yiliuTo yiliuTo commented Feb 1, 2021

This PR add a new IT for aad on-demand authorization feature.

  1. Create a unique test user each time the test is scheduled.
  2. Create java test code for on-demand case.

Note that due to #18774 hasn't been merged yet, thus changes to create test user are on tests.yml and don't involve Azure China tests. This will be improved after that PR is merged.

@ghost ghost added the azure-spring All azure-spring related issues label Feb 1, 2021
@yiliuTo
Copy link
Member Author

yiliuTo commented Feb 1, 2021

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yiliuTo
Copy link
Member Author

yiliuTo commented Feb 2, 2021

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@yiliuTo
Copy link
Member Author

yiliuTo commented Feb 2, 2021

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@yiliuTo
Copy link
Member Author

yiliuTo commented Feb 2, 2021

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link

@chenrujun chenrujun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yiliuTo
Copy link
Member Author

yiliuTo commented Feb 3, 2021

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@check-enforcer
Copy link

check-enforcer bot commented Feb 3, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@yiliuTo
Copy link
Member Author

yiliuTo commented Feb 3, 2021

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yiliuTo
Copy link
Member Author

yiliuTo commented Feb 3, 2021

/check-enforcer override

@yiliuTo yiliuTo merged commit 1cc0be6 into Azure:master Feb 3, 2021
@saragluna saragluna added the azure-spring-aad Spring active directory related issues. label Feb 4, 2021
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request May 24, 2022
[Hub Generated] Review request for Microsoft.VirtualMachineImages to add version stable/2022-02-14 (Azure#18896)

* Adds base for updating Microsoft.VirtualMachineImages from version stable/2021-10-01 to version 2022-02-14

* Updates readme

* Updates API version in new specs and examples

* adding 2022 changes

* fixed proxy resource path

* added object to ImageTemplate*

* added object to valide and prettier to examples

* added identifier

* removed format integer 32 for breaking change

* added back format integer 64, to be in compliance for lintdiff and breaking change

* adding back int32 after getting jeffrey richters approval
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azure-spring All azure-spring related issues azure-spring-aad Spring active directory related issues.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants