Closed
Conversation
jacko9et
requested review from
backwind1233,
chenrujun,
jialindai,
saragluna and
yiliuTo
as code owners
ghost
added
the
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
chenrujun
suggested changes
Dec 28, 2020
chenrujun
left a comment
chenrujun
left a comment
There was a problem hiding this comment.
IMU, It is overdesigned in this PR.
My suggestions:
- Rename
SeleniumTestUtilstoSeleniumAADTestHelper. - Add methods in
SeleniumAADTestHelper: constructor,property(...),login(),httpGetAndAssertEquals(...),httpGetAndAssertNotEquals(...),logout().
sdk/spring/azure-spring-boot-test-aad/src/test/java/com/azure/test/aad/login/AADLoginIT.java
Outdated
Show resolved
Hide resolved
...ing/azure-spring-boot-test-aad/src/test/java/com/azure/test/aad/selenium/AADLoginRunner.java
Show resolved
Hide resolved
...ing/azure-spring-boot-test-aad/src/test/java/com/azure/test/aad/selenium/AADLoginRunner.java
Show resolved
Hide resolved
...ing/azure-spring-boot-test-aad/src/test/java/com/azure/test/aad/selenium/AADLoginRunner.java
Outdated
Show resolved
Hide resolved
� Conflicts: � sdk/spring/azure-spring-boot-test-aad/src/test/java/com/azure/test/aad/selenium/access/token/scopes/AccessTokenScopesIT.java
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Closing this PR, the commits will be included in this PR: #18378 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add logout test