Skip to content

Deleted authorities created by scope.#17849

Merged
chenrujun merged 1 commit intoAzure:masterfrom
chenrujun:delete-authorities-created-by-scope
Nov 27, 2020
Merged

Deleted authorities created by scope.#17849
chenrujun merged 1 commit intoAzure:masterfrom
chenrujun:delete-authorities-created-by-scope

Conversation

@chenrujun
Copy link

Deleted authorities created by scope.

@ghost ghost added the azure-spring All azure-spring related issues label Nov 27, 2020
Copy link
Member

@yiliuTo yiliuTo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenrujun chenrujun merged commit 8a71786 into Azure:master Nov 27, 2020
@chenrujun chenrujun deleted the delete-authorities-created-by-scope branch November 27, 2020 08:12
@saragluna
Copy link
Member

Why are we remove scopes authorities here?

@chenrujun
Copy link
Author

@saragluna

Originally(last release), we do not have authority like SCOPE_Calender.Read.

But add authority like SCOPE_Calender.Read is default behavior of OidcUserService, So I added it recently.

Then I found it may have problem like this:

If we have resource-server-a has scope Calendar.Read, and resource-server-b also has scope Calendar.Read, Then we can not differentiate where SCOPE_Calender.Read comes from. So I deleted it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azure-spring All azure-spring related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants