validate access token by ZhuXiaoBing-cn · Pull Request #17613 · Azure/azure-sdk-for-java

ZhuXiaoBing-cn · 2020-11-17T04:38:57Z

Make changes according to checkstyle
add unit tests
pom file add resource-server dependencies
spring.factories file add autoconfiguration

* add unit tests * pom file add resource-server dependencies * spring.factories file add autoconfiguration

* update AADResourceServerAutoConfiguration * update AADResourceServerAutoConfigurationTest

* issuer validator verify that the STS URI matches * Verify the audience through AppIdUri * update unit test * Update JwkKeySetUri to get via ServiceEndpoints

…hentication

check-enforcer · 2020-11-19T07:44:31Z

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

...zure-spring-boot/src/main/java/com/azure/spring/autoconfigure/aad/AADJwtIssuerValidator.java

...re-spring-boot/src/main/java/com/azure/spring/autoconfigure/aad/AADJwtAudienceValidator.java

saragluna · 2020-11-20T02:49:19Z

...main/java/com/azure/spring/autoconfigure/aad/AzureJwtBearerTokenAuthenticationConverter.java

+        try {
+            jwsObject = JWSObject.parse(accessToken.getTokenValue());
+        } catch (ParseException e) {
+            e.printStackTrace();


need any log info here?

should we throw this exception?

We should have a log here.

...main/java/com/azure/spring/autoconfigure/aad/AzureJwtBearerTokenAuthenticationConverter.java

saragluna · 2020-11-20T02:51:49Z

...src/test/java/com/azure/spring/autoconfigure/aad/AADResourceServerAutoConfigurationTest.java

+import org.springframework.security.oauth2.jwt.JwtDecoder;
+import org.springframework.security.oauth2.jwt.NimbusJwtDecoder;
+
+public class AADResourceServerAutoConfigurationTest {


We need more test cases in this one

.../java/com/azure/spring/autoconfigure/aad/AzureJwtBearerTokenAuthenticationConverterTest.java

* add more unit test

...t/src/main/java/com/azure/spring/aad/resource/AzureActiveDirectoryResourceConfiguration.java

...azure-spring-boot/src/main/java/com/azure/spring/aad/resource/AzureJwtAudienceValidator.java

.../src/main/java/com/azure/spring/aad/resource/AzureJwtBearerTokenAuthenticationConverter.java

saragluna · 2020-11-23T02:57:47Z

Please fix the spotbug error.

...in/java/com/azure/spring/aad/resource/server/AzureJwtBearerTokenAuthenticationConverter.java

* add unit test

# Conflicts: # sdk/spring/azure-spring-boot/src/main/java/com/azure/spring/aad/implementation/AzureActiveDirectoryProperties.java

* For AzureOAuth2AuthenticatedPrincipal add multiple constructors, to implement change authoritiesClaimName, authorityPrefix. * Changes the PreAuthenticatedAuthenticationToken to BearerTokenAuthentication in AzureJwtBearerTokenAuthenticationConverter. * add unit test in AzureJwtBearerTokenAuthenticationConverterTest.

saragluna

Overall is great, we need to discuss the bearer token converter again, to see whether we use the correct abstraction here.

saragluna · 2020-11-26T01:55:04Z

/azp run java - spring - tests

azure-pipelines · 2020-11-26T01:55:15Z

Azure Pipelines successfully started running 1 pipeline(s).

saragluna

LGTM

saragluna · 2020-11-26T03:25:59Z

...in/java/com/azure/spring/aad/resource/server/AzureJwtBearerTokenAuthenticationConverter.java

+import org.springframework.util.Assert;
+
+/**
+ * A {@link Converter} that takes a {@link Jwt} and converts it into a {@link PreAuthenticatedAuthenticationToken}.


Change this doc.

* Make changes according to checkstyle

29b5cd0

* add unit tests * pom file add resource-server dependencies * spring.factories file add autoconfiguration

ZhuXiaoBing-cn requested review from backwind1233, chenrujun, jialindai, saragluna and yiliuTo as code owners November 17, 2020 04:38

ghost added the azure-spring All azure-spring related issues label Nov 17, 2020

ZhuXiaoBing-cn mentioned this pull request Nov 17, 2020

validate access token #17566

Closed

* Make changes according to checkstyle

081cb82

ZhuXiaoBing-cn requested review from JimSuplizio, alzimmermsft, danieljurek, mitchdenny and samvaity as code owners November 17, 2020 05:58

ZhuXiaoBing-cn added 4 commits November 17, 2020 14:24

* Make changes according to checkstyle

c8a3508

* add JavaDoc

b9aa067

* update AADResourceServerAutoConfiguration * update AADResourceServerAutoConfigurationTest

* remove tenant validator

fdfb007

* issuer validator verify that the STS URI matches * Verify the audience through AppIdUri * update unit test * Update JwkKeySetUri to get via ServiceEndpoints

* add Converter,it's effect will be to store the UserPrincipal to Aut…

bddc2e4

…hentication

ZhuXiaoBing-cn and others added 2 commits November 19, 2020 15:49

Merge branch 'master' into access_token_validate

cb82a9b

Merge branch 'master' into access_token_validate

0732746

saragluna requested changes Nov 20, 2020

View reviewed changes

ZhuXiaoBing-cn added 4 commits November 20, 2020 18:19

* update file name

3f8dac0

* add more unit test

* Make changes according to checkstyle

4b6e974

Merge branch 'master' into access_token_validate

ce65efe

* Make changes according to checkstyle

05d929d

saragluna requested changes Nov 23, 2020

View reviewed changes

ZhuXiaoBing-cn added 2 commits November 23, 2020 14:15

* Make changes according to checkstyle

4e4d053

* Make changes according to checkstyle

b362dfb

ZhuXiaoBing-cn and others added 3 commits November 23, 2020 14:18

* Make changes according to checkstyle

ae39fe7

* update AzureJwtBearerTokenAuthenticationConverter

acaeefa

Merge branch 'master' into access_token_validate

d25e9df

saragluna requested changes Nov 24, 2020

View reviewed changes

...in/java/com/azure/spring/aad/resource/server/AzureJwtBearerTokenAuthenticationConverter.java Outdated Show resolved Hide resolved

ZhuXiaoBing-cn added 6 commits November 25, 2020 09:46

* add AzureOAuth2AuthenticatedPrincipal

a31f1a6

* add unit test

Merge branch 'master' into access_token_validate

f7aa628

# Conflicts: # sdk/spring/azure-spring-boot/src/main/java/com/azure/spring/aad/implementation/AzureActiveDirectoryProperties.java

* update AzureActiveDirectoryResourceServerConfiguration

0851fc6

* Make changes according to checkstyle

0ac20f9

* update unit test

fd2155b

saragluna reviewed Nov 26, 2020

View reviewed changes

* Modify invalid import

7403602

saragluna approved these changes Nov 30, 2020

View reviewed changes

saragluna merged commit 9165125 into Azure:master Nov 30, 2020

ZhuXiaoBing-cn deleted the access_token_validate branch November 30, 2020 03:47

Conversation

ZhuXiaoBing-cn commented Nov 17, 2020

Uh oh!

check-enforcer bot commented Nov 19, 2020

What is Check Enforcer?

Why am I getting this message?

What should I do now?

What if I am onboarding a new service?

Uh oh!

Uh oh!

Uh oh!

saragluna Nov 20, 2020

Choose a reason for hiding this comment

Uh oh!

saragluna Nov 20, 2020

Choose a reason for hiding this comment

Uh oh!

ZhuXiaoBing-cn Nov 20, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

saragluna Nov 20, 2020

Choose a reason for hiding this comment

Uh oh!

ZhuXiaoBing-cn Nov 20, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

saragluna commented Nov 23, 2020

Uh oh!

Uh oh!

saragluna left a comment

Choose a reason for hiding this comment

Uh oh!

saragluna commented Nov 26, 2020

Uh oh!

azure-pipelines bot commented Nov 26, 2020

Uh oh!

saragluna left a comment

Choose a reason for hiding this comment

Uh oh!

saragluna Nov 26, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants